Add alerts for timesync and disconnection#1799
Merged
mcm001 merged 18 commits intoPhotonVision:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
|
My new Java unit test makes me happy with that stuff. Someone should port that to c++. |
mcm001
reviewed
Mar 7, 2025
photon-lib/src/test/java/org/photonvision/PhotonCameraTest.java
Outdated
Show resolved
Hide resolved
spacey-sooty
requested changes
Mar 10, 2025
Member
spacey-sooty
left a comment
spacey-sooty
left a comment
There was a problem hiding this comment.
Make a seperate group for Photon alerts
mcm001
approved these changes
Mar 10, 2025
mcm001
force-pushed
the
disconnect-alert
branch
4 times, most recently
from
6d0e5e8 to
25b54c1
Compare
Member
|
Test is failing on mac |
Contributor
|
Yeah and i have no idea why |
This reverts commit 25b54c1.
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
mcm001
force-pushed
the
disconnect-alert
branch
from
906b670 to
9ec596e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1798
Also adds missing C++ implementation for
IsConnected()along with heartbeat checking.Has not been tested yet.