Disable camera orientation option when camera is calibrated#1277
Merged
mcm001 merged 6 commits intoPhotonVision:masterfrom Mar 15, 2024
Merged
Conversation
mcm001
approved these changes
Mar 15, 2024
Contributor
Author
|
@mcm001 Thanks for your help with this! I will make sure to run the linter next time. |
7 tasks
samfreund
pushed a commit
that referenced
this pull request
Feb 20, 2026
Around a year ago, this PR #1277 added checks to make sure that users weren't enabling camera rotation when they calibrated their cameras as a stop gap to Issue #1084 However PR #1464 has resolved this issue (see #1084 (comment)) and I wanted to update the orientation tooltip in the dashboard to reflect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stop gap for issue #1084. The input option is disabled for camera rotation when the active camera has been calibrated based on
useCameraSettingsStore().isCurrentVideoFormatCalibratedLong term fix should be to use the rotation data for calibrated camera pipelines.