Skip to content

Disable camera orientation option when camera is calibrated #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcm001 merged 6 commits into from
Mar 15, 2024
Merged

Disable camera orientation option when camera is calibrated #1277

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53c5cf1
Disable camera orientation option when camera is calibrated.
philltran Mar 14, 2024
31b3642
Flip logic on if camera is calibrated when disabling camera orientati…
philltran Mar 14, 2024
5c3d640
Add comment on why orientation is disabled when camera is calibrated
philltran Mar 14, 2024
5dfaa9e
Add v banner warning regarding rotating calibrated camera bug
philltran Mar 15, 2024
27594ad
Merge branch 'master' into philltran/disable-orientation-when-calibrated
philltran Mar 15, 2024
b8e868b
Run lint
mcm001 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion photon-client/src/components/dashboard/tabs/InputTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,32 @@ const interactiveCols = computed(() =>
tooltip="Controls blue automatic white balance gain, which affects how the camera captures colors in different conditions"
@input="(args) => useCameraSettingsStore().changeCurrentPipelineSetting({ cameraBlueGain: args }, false)"
/>
<!-- Disable camera orientation as stop gap for Issue 1084 until calibration data gets rotated. https://github.com/PhotonVision/photonvision/issues/1084 -->
<v-banner
v-show="
useCameraSettingsStore().isCurrentVideoFormatCalibrated &&
useCameraSettingsStore().currentPipelineSettings.inputImageRotationMode != 0
"
rounded
dark
color="red"
text-color="white"
class="mt-3"
icon="mdi-alert-circle-outline"
>
Warning! A known bug affects rotation of calibrated camera. Turn off rotation here and rotate using
cameraToRobotTransform in your robot code.
</v-banner>
<pv-select
v-model="useCameraSettingsStore().currentPipelineSettings.inputImageRotationMode"
label="Orientation"
tooltip="Rotates the camera stream"
tooltip="Rotates the camera stream. Rotation not available when camera has been calibrated."
:items="cameraRotations"
:select-cols="interactiveCols"
:disabled="
useCameraSettingsStore().isCurrentVideoFormatCalibrated &&
useCameraSettingsStore().currentPipelineSettings.inputImageRotationMode == 0
"
@input="(args) => useCameraSettingsStore().changeCurrentPipelineSetting({ inputImageRotationMode: args }, false)"
/>
<pv-select
Expand Down