Merged
Conversation
Contributor
|
|
mcm001
reviewed
Oct 15, 2024
photon-core/src/main/java/org/photonvision/vision/frame/FrameStaticProperties.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Oct 15, 2024
...on-core/src/main/java/org/photonvision/vision/calibration/CameraCalibrationCoefficients.java
Outdated
Show resolved
Hide resolved
mcm001
force-pushed
the
RotateCalibration
branch
from
3fbc544 to
8e3b2ef
Compare
mcm001
reviewed
Oct 17, 2024
photon-core/src/main/java/org/photonvision/vision/frame/FrameStaticProperties.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Oct 17, 2024
| private void calculateFrameStaticProps() { | ||
| var videoMode = getCurrentVideoMode(); | ||
| if (this.frameStaticProperties != null) { | ||
| this.frameStaticProperties.release(); |
Contributor
There was a problem hiding this comment.
Commenting this out makes photon actually boot...
Contributor
|
Starting camera calibration also causes the camera feed to disappear. |
mcm001
approved these changes
Oct 18, 2024
mcm001
requested changes
Oct 18, 2024
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
Still need to hammer out camera calibration ownership
mcm001
requested changes
Oct 18, 2024
photon-core/src/main/java/org/photonvision/common/configuration/CameraConfiguration.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceSettables.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Oct 19, 2024
Gold856
added
documentation
7 tasks
samfreund
pushed a commit
that referenced
this pull request
Feb 20, 2026
Around a year ago, this PR #1277 added checks to make sure that users weren't enabling camera rotation when they calibrated their cameras as a stop gap to Issue #1084 However PR #1464 has resolved this issue (see #1084 (comment)) and I wanted to update the orientation tooltip in the dashboard to reflect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It needs some work.