[Qt5][C++] Renamed cpp-qt5-client to cpp-qt-client. #8334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update version to 5.0.1-SNAPSHOT * update samples * update meta codegen
* add badge for 5.1.x branch * add badge for 6.0.0 * minor change * update pr tempalte
* fix for Deno 1.6 * update dependency version of Deno test code
…#8054) Added a Set<String> in toExampleValueRecursive() to keep track of which models we have generated to avoid an infinite recursion for recursive models. An example of a recursive model would be a GeoJson GeometryCollection. Co-authored-by: Frank Levine <[email protected]>
* [swift5] add URLResponse to ErrorResponse * [swift] improve unit tests * [swift] improve unit tests
…Package settings (#8272)
…cation (#8302) * [swift] create a sample of bearer token authentication with URLSession * [swift] create a sample of bearer token authentication with URLSession * [swift] create a sample of bearer token authentication with URLSession * [swift] create a sample of bearer token authentication with URLSession * [swift] create a sample of bearer token authentication with Alamofire * [swift] create a sample of bearer token authentication with Alamofire
#7976) * 7141: filter out problem+json mime type from JSON mime types fast tracked into the Accept header (resttemplate) * 7141: ran ensure-up-to-date * 7141: minimize changes with master (keep using isJsonMime for MediaType)
* ran `mvn -N io.takari:maven:0.7.7:wrapper` * this fixes colored output not working in zsh/MacOs/BigSur, not exactly sure what caused it not to work anymore
* [Swift 5] deprecated retry hook since its no longer needed * [Swift 5] deprecated retry hook since its no longer needed * [swift] fix generator code formatting
…LEncoded enconding (#8275) * [swift5] fix issue with form data with null file * [swift5] fix issue with form data with null file on alamofire implementation * [swift5] update sample projects * [swift5] fix issue with form data with null file on alamofire implementation * [swift5] add support for form url enconded in URLSession * [swift5] add support for form url enconded in Alamofire * [swift] improve code formatting * [swift] improve code formatting * [swift] dont defaut to application/json
#6384) * Updates samples * Handles primitive types
* [dart-dio] Enable strong-mode and strict types This will make it easier to eventually transition to NNBD. Also fix some formatting things. * [dart-dio] Add implicit-casts: false to analysis options * [dart-dio] Add dartanalyzer to integration tests * raise minimum Dart version to 2.6 (to support spread collection) * add header to all files for language version * fix some missing imports that can be fixed (some remain due to missing inheritance support)
…#8306) * empty arrays are now correctly generated * default arrays with values are empty * date/dateTime is now always null in order to prevent compile errors
* ignre docker login error * trigger faiure * Revert "trigger faiure" This reverts commit ce17593.
…then the C client can be compiled by C++ compiler (#8205) * [C][Client] Add cpp reserved keywords to C-libcurl client generator * update doc Co-authored-by: William Cheng <[email protected]>
Contributor
Author
|
is the circleci build failure caused by those changes? I took a look and it seems like its unrelated. |
Member
|
Thanks for the PR. Let me check. Since this change is a breaking change with fallback, we'll need to target this change for version 5.1.0 instead. |
Contributor
Author
all right! |
muttleyxd
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.xThis PR will rename the generator for
cpp-qt5-clienttocpp-qt-client. The reason behind this, is the release of Qt6. In Qt6 there are some deprecated functions that are "removed" in PR #8234. @wing328 suggested to rename the generator to justQtsince it now supports Qt5 and Qt6. The only changes are the removal of all occurrences of the 5s in every file. I did not change thecpp-qt5-qhttpengine-serverthough since I did not change possibly deprecated functions in this generator.PING @wing328 @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)