Skip to content

Conversation

@nmuesch
Copy link
Contributor

@nmuesch nmuesch commented Nov 19, 2020

Use Map instead of HashMap for the configureApiKeys method in the Java client. This allows users to pass in whatever implementation of Map they'd like. This pattern is used elsewhere throughout the java client currently.

This addresses an issue raised here - DataDog/datadog-api-client-java#513

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@nmuesch
Copy link
Contributor Author

nmuesch commented Nov 19, 2020

Copying the technical committee for Java:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@nmuesch
Copy link
Contributor Author

nmuesch commented Dec 14, 2020

Hey, just wanted to followup here to see if there was anything I could do to further this. Thanks!

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wing328 wing328 modified the milestones: 5.0.0, 5.0.1 Dec 21, 2020
@wing328 wing328 merged commit 00d5637 into OpenAPITools:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants