-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Resttemplate] Filter out problem+json mime type from JSON mime types #7976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resttemplate] Filter out problem+json mime type from JSON mime types #7976
Conversation
|
CC Java Technical Committee @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01) |
|
@ajeans thanks for the PR. Can you please run |
|
@wing328 I just ran the script, but there is nothing to commit after the script ran... |
…cked into the Accept header (resttemplate)
a69cf8b to
f3c8eb7
Compare
f3c8eb7 to
20a4db8
Compare
|
Oh right, PEBKAC, I had a stale Llooking into this, it should have been refreshed by the mvn invocation in Anyway @wing328 , looks good to me now, rebased on top of master, original commit first on top, then the sample changes... |
|
And a third commit on top to make sure we use the same method as before. Spring resttemplate has a |
|
@ajeans thanks for the PR, which looks reasonable to me. |
Fast tracked into the Accept header (resttemplate)
See full details at issue #7141
The issue is that the Accept header may use a single mime type rather than all mime types advertized in the spec if it is a JSON mime type.
However,
application/problem+jsonqualifies as a JSON mime type so is fast tracked, but a standard server (e.g. spring boot) will reject a request that only accepts the error responses and not the standard responses.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master