Skip to content

fix: replace legacy eth-json-rpc deps#11952

Merged
NicolasMassart merged 60 commits intomainfrom
chore/provider-middleware-filters-2
Dec 13, 2024
Merged

fix: replace legacy eth-json-rpc deps#11952
NicolasMassart merged 60 commits intomainfrom
chore/provider-middleware-filters-2

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2024 •
edited by NicolasMassart
Loading

Description

Related issues

Expected to fix the following issues:

Blocked by

Manual testing steps

  1. Go to in-app browser
  2. Test connect with multiple dapps
  3. Perform transaciton on test dapp
  4. Go to this page...

Screenshots/Recordings

Screen.Recording.2024-06-24.at.22.46.41.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 22, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@socket-security
Copy link

socket-security bot commented Oct 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-mobile-platform Mobile Platform team Run Smoke E2E labels Oct 22, 2024
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the chore/provider-middleware-filters-2 branch 2 times, most recently from 45873d6 to f68a6cf Compare October 22, 2024 12:56
@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat mentioned this pull request Oct 22, 2024
Closed
7 tasks
@legobeat legobeat marked this pull request as ready for review October 22, 2024 13:32
@legobeat legobeat requested review from a team as code owners October 22, 2024 13:32
@legobeat legobeat requested a review from a team October 22, 2024 13:32
@legobeat legobeat requested review from a team as code owners October 22, 2024 13:32
@legobeat legobeat force-pushed the chore/provider-middleware-filters-2 branch from f68a6cf to 8dbb040 Compare October 22, 2024 13:36
@github-actions

This comment was marked as outdated.

Sign in to view
@joaoloureirop joaoloureirop mentioned this pull request Dec 12, 2024
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 0080a0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c31fd27e-6832-4eac-96f7-1fa080018a93

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 12, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0080a0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c31fd27e-6832-4eac-96f7-1fa080018a93

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddca0592-f834-440e-bd6f-8a5dac2a7705

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddca0592-f834-440e-bd6f-8a5dac2a7705

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

1 similar comment
@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddca0592-f834-440e-bd6f-8a5dac2a7705

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e085b562-0bde-49b9-bce7-70ae2c0a5074

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

2 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e085b562-0bde-49b9-bce7-70ae2c0a5074

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86b9fd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e085b562-0bde-49b9-bce7-70ae2c0a5074

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

EtherWizard33
EtherWizard33 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving my previous approval :)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

1 similar comment
@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

ccharly
ccharly approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for accounts related files:

app/core/Encryptor/pbkdf2.test.ts

christopherferreira9
christopherferreira9 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for SDK

GuillaumeRx
GuillaumeRx approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the snap side ✔️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

@joaoloureirop joaoloureirop joaoloureirop approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@smilingkylan smilingkylan Awaiting requested review from smilingkylan

@tommasini tommasini Awaiting requested review from tommasini

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@owencraston owencraston Awaiting requested review from owencraston

@gantunesr gantunesr Awaiting requested review from gantunesr

@Cal-L Cal-L Awaiting requested review from Cal-L

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@jclancy93 jclancy93 Awaiting requested review from jclancy93

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

+1 more reviewer

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NicolasMassart NicolasMassart

Labels

dependencies Pull requests that update a dependency file external-contributor release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-mobile-platform Mobile Platform team team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.