Skip to content

fix: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8#12085

Merged
smilingkylan merged 3 commits intomainfrom
deps-mm-providers-16
Nov 6, 2024
Merged

fix: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8#12085
smilingkylan merged 3 commits intomainfrom
deps-mm-providers-16

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 29, 2024 •
edited
Loading

Description

  • Upgrade @metamask/providers from ^13.1.0 to ^16.1.0
  • Upgrade from json-rpc-middleware-stream@^4.2.3 to @metamask/json-rpc-middleware-stream@^8.0.2

Removes usage of depecated json-rpc-middleware-stream@4.2.3, extension-port-stream

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 29, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/json-rpc-middleware-stream@4.2.3

View full report↗︎

@legobeat legobeat mentioned this pull request Oct 29, 2024
Closed
12 tasks
@legobeat legobeat changed the title deps: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8 fix: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8 Oct 29, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E and removed team-lavamoat labels Oct 29, 2024
@legobeat legobeat marked this pull request as ready for review October 29, 2024 22:16
@legobeat legobeat requested review from a team as code owners October 29, 2024 22:16
@legobeat legobeat requested a review from a team October 29, 2024 22:16
@legobeat legobeat requested a review from a team as a code owner October 29, 2024 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bf0c43b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d4e6ec25-8ae7-4a4e-ad09-1341b94bbe3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Oct 29, 2024
Closed
8 tasks
@legobeat legobeat added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Oct 29, 2024
@legobeat legobeat force-pushed the deps-mm-providers-16 branch from bf0c43b to 4bce069 Compare October 30, 2024 01:56
@legobeat legobeat mentioned this pull request Oct 30, 2024
Merged
23 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4bce069
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ecc9a5ea-3252-4732-9cf1-bff5b5368987

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

smilingkylan
smilingkylan approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 753e2ea Nov 6, 2024
@smilingkylan smilingkylan deleted the deps-mm-providers-16 branch November 6, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

+1 more reviewer

@smilingkylan smilingkylan smilingkylan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-application-security Application security team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @FrederikBolding @smilingkylan @metamaskbot @sethkfman