fix: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11#12047
Merged
fix: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11#12047
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
legobeat
added
dependencies
Contributor
|
7 tasks
legobeat
force-pushed
the
deps-eth-json-rpc-filters-8
branch
from
887febd to
1a73659
Compare
legobeat
force-pushed
the
deps-eth-json-rpc-middleware-11
branch
from
7b2b592 to
6c0690a
Compare
legobeat
force-pushed
the
deps-eth-json-rpc-filters-8
branch
2 times, most recently
from
5de4d65 to
91fbb80
Compare
legobeat
force-pushed
the
deps-eth-json-rpc-middleware-11
branch
from
6c0690a to
b6d0556
Compare
Contributor
|
legobeat
force-pushed
the
deps-eth-json-rpc-filters-8
branch
from
91fbb80 to
965efb0
Compare
legobeat
force-pushed
the
deps-eth-json-rpc-middleware-11
branch
from
b6d0556 to
ff38c03
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…^8.0.0 (#12024) ## **Description** Replace deprecated `eth-json-rpc-filters` with `@metamask/eth-json-rpc-filters`. ## **Related issues** - Part of: #12047 - Broken out from: #9274, #11952 - Follow-up to: #11980 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
legobeat
force-pushed
the
deps-eth-json-rpc-middleware-11
branch
from
ff38c03 to
47d6dbd
Compare
Contributor
|
23 tasks
tommasini
approved these changes
Oct 29, 2024
|
legobeat
changed the title
FrederikBolding
approved these changes
Oct 29, 2024
metamaskbot
added
the
release-7.35.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate from legacy
eth-json-rpc-middlewareto@metamask/eth-json-rpc-middleware, holding at v11.Removes usage of
eth-block-trackerv5.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist