-
Notifications
You must be signed in to change notification settings - Fork 30
Fix tests on Julia 1.8-beta1 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Dilum Aluthge <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
|
Can someone approve the workflow? |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 93.79% 93.81% +0.02%
==========================================
Files 13 13
Lines 2208 2265 +57
==========================================
+ Hits 2071 2125 +54
- Misses 137 140 +3
Continue to review full report at Codecov.
|
|
The fixes look like they are working around regressions so I don't think this should be merged as is. E.g. replacing @test apply(*, Eye(10), Ones(10)) ≡ Ones(10)is an issue: we want it to be identically a |
Do you have a suggestion on how to fix it? I think that the failures are due to the new representations for sparse matrices EDIT: Specifically, JuliaLang/julia#42577 |
|
Just need to step through the debugger and see what's going wrong |
| @test a .* v == v .* a | ||
|
|
||
| @test n .+ n ≡ Vcat(2,Zeros{Int}(3)) | ||
| @test n .+ v ≡ n .+ v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this one because currently this doesn't even hold on Julia 1.8-beta1 (due to JuliaArrays/FillArrays.jl#172). Testing this may save a lot of time in the future when trying to figure out why n .+ v !== v .+ n.
|
Tests are still broken. Patch for FillArrays is at JuliaArrays/FillArrays.jl#172. |
|
Awesome! Thanks for fixing this and MatrixFactorizations, @dlfivefifty |
I've tested these changes on Julia 1.6, 1.7 and 1.8-beta1.
I've also changed
to
to avoid triggering the jobs for pushes and pull requests at the same time. See, for example, https://github.com/JuliaData/CSV.jl/blob/2c02394b4ce11ee673ed1b6d0c811a98316bc2f9/.github/workflows/ci.yml#L3-L5