Skip to content

Fix tests on Julia 1.8-beta1 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlfivefifty merged 9 commits into from
Mar 20, 2022
Merged

Fix tests on Julia 1.8-beta1 #205

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f79185
Fix tests on Julia 1.8-beta1
rikhuijzer Mar 5, 2022
4d1986b
Avoid double runs on PR
rikhuijzer Mar 5, 2022
325c221
Apply suggestions from code review
Mar 6, 2022
0aef086
Fix typo?
rikhuijzer Mar 6, 2022
b325e78
Fix CI
Mar 6, 2022
dcb54c7
Oops. Fix copy paste error
Mar 6, 2022
35e0249
Revert removal of egal
rikhuijzer Mar 7, 2022
bf56e16
Update Project.toml
dlfivefifty Mar 19, 2022
a6f6d9d
Update LazyArrays.jl
dlfivefifty Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: CI
on:
- push
- push:
branches:
- main
- pull_request
jobs:
test:
Expand All @@ -11,7 +13,8 @@ jobs:
matrix:
version:
- '1.6'
- '^1.7.0-0'
- '1' # Latest stable release
- '^1.8.0-0'
os:
- ubuntu-latest
- macOS-latest
Expand Down
8 changes: 6 additions & 2 deletions test/applytests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ import ArrayLayouts: StridedLayout
@test copyto!(b, a) == a == b
@test copyto!(c, a) == a == c
@test copyto!(similar(a), a) == a
@test_throws ErrorException copyto!(c, Array(a))
if VERSION ≤ v"1.7.99"
@test_throws ErrorException copyto!(c, Array(a))
else
@test_throws Base.CanonicalIndexError copyto!(c, Array(a))
end
end

@testset "view" begin
Expand Down Expand Up @@ -95,4 +99,4 @@ import ArrayLayouts: StridedLayout
@test arguments(R) == (rot180(A), rot180(B))
@test R ≈ rot180(A*B)
end
end
end
6 changes: 3 additions & 3 deletions test/multests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,8 +955,8 @@ end
@test apply(*, Diagonal(Fill(2,10)), Fill(3,10)) ≡ Diagonal(Fill(2,10)) * Fill(3,10) ≡ Fill(6,10)
@test apply(*, Diagonal(Fill(2,10)), Fill(3,10,3)) ≡ Diagonal(Fill(2,10)) * Fill(3,10,3) ≡ Fill(6,10,3)
@test apply(*,Fill(3,10,10),Fill(3,10)) ≡ Fill(3,10,10) * Fill(3,10) ≡ Fill(90,10)
@test apply(*, Eye(10), Ones(10)) ≡ Ones(10)
@test apply(*, Eye(10), Eye(10)) ≡ Eye(10)
@test apply(*, Eye(10), Ones(10)) == Ones(10)
@test apply(*, Eye(10), Eye(10)) == Eye(10)
end

@testset "ApplyArray MulTest" begin
Expand Down Expand Up @@ -1161,4 +1161,4 @@ end
A = ApplyArray(*, [1 2; 3 4], [1 2; 3 4], [1 2; 3 4])
@test A[:,1] == Matrix(A)[:,1]
end
end
end
4 changes: 2 additions & 2 deletions test/paddedtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ paddeddata(a::PaddedPadded) = a
@test a .* v == v .* a

@test n .+ n ≡ Vcat(2,Zeros{Int}(3))
@test n .+ v ≡ v .+ n ≡ Vcat(2,1:3)
@test n .+ v == v .+ n == Vcat(2,1:3)
@test n .+ b == b .+ n
@test n .+ a == a .+ n
@test n .+ c == c .+ n
Expand Down Expand Up @@ -314,4 +314,4 @@ paddeddata(a::PaddedPadded) = a
c = cache(Zeros(4)); c[1] = 1
@test norm(a) ≡ LinearAlgebra.normInf(c) ≡ LinearAlgebra.norm2(c) ≡ LinearAlgebra.norm1(c) ≡ LinearAlgebra.normp(c,2) ≡ 1.0
end
end
end