-
Notifications
You must be signed in to change notification settings - Fork 10
Switch to _copy_oftype
#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to _copy_oftype
#88
Conversation
With this, tests still pass on Julia 1.7.2. It doesn't fix 1.8-beta1 yet because there is some other problem too.
|
We need to make the compat entry require the version of FillArrays that introduces |
Codecov Report
@@ Coverage Diff @@
## master JuliaLang/julia#88 +/- ##
==========================================
- Coverage 85.38% 84.84% -0.55%
==========================================
Files 10 10
Lines 1553 1603 +50
==========================================
+ Hits 1326 1360 +34
- Misses 227 243 +16
Continue to review full report at Codecov.
|
|
There seems to be some changes to |
I just came across JuliaLang/julia#44674 so it seems you luckily have a solution for that now. Based on the reply that I got on JuliaLang/LinearAlgebra.jl#918, I've now changed the equality in The tests now still fail with |
|
I have the tests now working, about to push |
|
For me this is good to merge like this 👍 I cannot press the "approve review" button because I'm the author of the PR. |
Follow up on JuliaArrays/FillArrays.jl#172. Still part of trying to get LazyArrays to work on Julia 1.8-beta1: JuliaArrays/LazyArrays.jl#205.
With this change, the tests still pass on earlier Julia versions. Julia 1.8-beta1 fails which I've narrowed down to JuliaLang/LinearAlgebra.jl#918. Also, there is a problem with a missing
eltypefor a certain signature which I haven't been able to narrow down yet.