-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add architecture test for logging infrastructure #13534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
requested changes
Jul 13, 2025
test-support/src/main/java/org/jabref/support/CommonArchitectureTest.java
Outdated
Show resolved
Hide resolved
koppor
reviewed
Jul 13, 2025
test-support/src/main/java/org/jabref/support/CommonArchitectureTest.java
Show resolved
Hide resolved
…-archtest # Conflicts: # test-support/src/main/java/org/jabref/support/CommonArchitectureTest.java
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Jul 13, 2025
Member
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you!
Siedlerchr
added a commit
that referenced
this pull request
Aug 2, 2025
* upstream/main: Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541) Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532) New Crowdin updates (#13548) Add focus to field Link in the "Add file link" dialog. (#13520) Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547) Make validation optional for saving library properties preferences (#13488) Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546) --porcelain does not output any info or warn errors on the console (#13469) Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545) Refine "File exists" warning (#13491) Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544) Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542) Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540) Add architecture test for logging infrastructure (#13534) More harsh test on title of PR New Crowdin updates (#13533) Update extra-java-module-info plugin (#13527) [Junie]: fix: display help output for --help argument (#13446) Refactor OpenExternalFileAction (#13508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: logging
dev: architecture
dev: code-quality
Issues related to code or architecture decisions
dev: testing
Related to tests
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/946
Steps to test
Run JabGuiArchitectureTests and JabLibArchitectureTests
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)