Refine "File exists" warning #13491

Sara-S-Dev · 2025-07-07T07:22:49Z

fixes #12565 refine file exists warning

Allow "Keep both" option to avoid overwriting files
Add tooltip showing the new unique filename
Add "Provide alternative file name" option
Improve title and message content for better clarity

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor

Code looks OK - someone needs to try out.

koppor · 2025-07-07T09:31:26Z

jablib/src/main/resources/l10n/JabRef_en.properties


 Do\ not\ wrap\ when\ saving=Do not wrap when saving

+File\ already\ exists=File already exists


Pleae group to line 2999

(there is File '%0' already exists. Overwriting.)

subhramit · 2025-07-07T17:15:34Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

+            // Build the dialog window
+            Dialog<ButtonType> dialog = new Dialog<>();
+            dialog.setTitle(Localization.lang("File already exists"));
+            dialog.setContentText(Localization.lang("File name: \n'%0'", targetFileName));
+            dialog.getDialogPane().getButtonTypes().addAll(Replace, keepBoth, provideAlternative, cancel);


I don't think this should be in viewmodel

koppor · 2025-07-07T19:26:59Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

+            ButtonType cancel = new ButtonType(Localization.lang("Cancel"), ButtonBar.ButtonData.OTHER);
+
+            // Build the dialog window
+            Dialog<ButtonType> dialog = new Dialog<>();


Please rework. Use org.jabref.gui.JabRefDialogService. Please do not create dialogs on your own. - For example, look at the removed code 😅

MVVM is about testability.

This will also help to test this --> try to craft a test case after you use the JabRefDialogService :)

I created a custom modal because the current JabRefDialogService methods don’t support tooltips on buttons.
Should I add a new function to JabRefDialogService for this, or is there a better approach you’d recommend?

Yes please add a new function, maybe with a supplier as parameter for the tool tips

jabgui/src/main/java/org/jabref/gui/JabRefDialogService.java

Siedlerchr · 2025-07-14T14:14:05Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

+            ButtonType replace = new ButtonType(Localization.lang("Replace"), ButtonBar.ButtonData.OTHER);
+            ButtonType keepBoth = new ButtonType(Localization.lang("Keep both"), ButtonBar.ButtonData.OTHER);
+            ButtonType provideAlternative = new ButtonType(Localization.lang("Provide alternative file name"), ButtonBar.ButtonData.OTHER);
+            ButtonType cancel = new ButtonType(Localization.lang("Cancel"), ButtonBar.ButtonData.OTHER);


should be cancel close for button data

trag-bot · 2025-07-14T17:36:07Z

@trag-bot didn't find any issues in the code! ✅✨

solved

koppor · 2025-07-29T12:04:18Z

jablib/src/main/resources/l10n/JabRef_en.properties

 Do\ not\ wrap\ when\ saving=Do not wrap when saving

+File\ already\ exists=File already exists
+File\ name\:\ \n'%0'=File name: \n'%0'


There should be no space before newline

Maybe you can submit a follow-up PR?

* upstream/main: Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541) Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532) New Crowdin updates (#13548) Add focus to field Link in the "Add file link" dialog. (#13520) Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547) Make validation optional for saving library properties preferences (#13488) Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546) --porcelain does not output any info or warn errors on the console (#13469) Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545) Refine "File exists" warning (#13491) Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544) Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542) Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540) Add architecture test for logging infrastructure (#13534) More harsh test on title of PR New Crowdin updates (#13533) Update extra-java-module-info plugin (#13527) [Junie]: fix: display help output for --help argument (#13446) Refactor OpenExternalFileAction (#13508)

Sara-S-Dev added 8 commits July 4, 2025 11:17

gradle file changes

26636e2

Merge branch 'main' into fix-issue-12565

5fd2a8c

refine file exists warning - Fixes JabRef#12565

8e7591d

Revert unintended change to settings.gradle.kts

06674e5

fix: add missing localization keys

fb8f718

fix: add missing localization key for 'New filename'

6059ffe

Merge branch 'main' into fix-issue-12565

70455bc

Merge branch 'main' into fix-issue-12565

6bb7287

koppor reviewed Jul 7, 2025

View reviewed changes

koppor changed the title ~~Fix issue 12565~~ Refine "File exists" warning Jul 7, 2025

subhramit reviewed Jul 7, 2025

View reviewed changes

koppor previously requested changes Jul 7, 2025

View reviewed changes

Sara-S-Dev added 2 commits July 14, 2025 14:26

Refactor: Use JabRefDialogService instead of direct dialog creation

865f839

Merge branch 'main' into fix-issue-12565

eada06a

trag-bot bot reviewed Jul 14, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/JabRefDialogService.java Show resolved Hide resolved

fixed checkstyle issue

560174e

Sara-S-Dev requested a review from koppor July 14, 2025 13:16

Siedlerchr reviewed Jul 14, 2025

View reviewed changes

Use CANCEL_CLOSE for Cancel button

6b0c081

Siedlerchr approved these changes Jul 14, 2025

View reviewed changes

Siedlerchr enabled auto-merge July 14, 2025 18:38

Siedlerchr added this pull request to the merge queue Jul 14, 2025

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 14, 2025

auto-merge was automatically disabled July 14, 2025 18:50
Pull Request is not mergeable

Merged via the queue into JabRef:main with commit 66393da Jul 14, 2025
1 check passed

github-actions bot mentioned this pull request Jul 14, 2025

Refine "File exists" warning #12565

Closed

koppor reviewed Jul 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Refine "File exists" warning #13491

Refine "File exists" warning #13491

Uh oh!

Sara-S-Dev commented Jul 7, 2025 •

edited

Loading

Uh oh!

koppor left a comment

Uh oh!

koppor Jul 7, 2025

Uh oh!

subhramit Jul 7, 2025

Uh oh!

koppor Jul 7, 2025

Uh oh!

Sara-S-Dev Jul 8, 2025

Uh oh!

Siedlerchr Jul 8, 2025

Uh oh!

Uh oh!

Siedlerchr Jul 14, 2025

Uh oh!

trag-bot bot commented Jul 14, 2025

Uh oh!

Uh oh!

koppor Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		Do\ not\ wrap\ when\ saving=Do not wrap when saving

		File\ already\ exists=File already exists

Uh oh!

Refine "File exists" warning #13491

Refine "File exists" warning #13491

Uh oh!

Conversation

Sara-S-Dev commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

koppor Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

subhramit Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

koppor Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

Sara-S-Dev Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Siedlerchr Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

trag-bot bot commented Jul 14, 2025

Uh oh!

Uh oh!

koppor Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sara-S-Dev commented Jul 7, 2025 •

edited

Loading