Skip to content

Conversation

@paudelritij
Copy link
Contributor

@paudelritij paudelritij commented Jul 7, 2025

Closes #11840
Follow-up #12867

This pull request improves file directory handling by making validation optional when saving preferences, enhancing error messaging for clarity, and streamlining the user experience to allow saving even with inaccessible directories.

Steps to test

  1. Launch JabRef on the first machine and navigate to the Library Properties.
  2. Set a valid file directory (e.g., Library-specific) in the properties.
  3. Save the changes made to the library properties.
  4. Launch JabRef on the second machine, ensuring that the directory defined in step 2 is not present.
  5. Go to Library Properties and make changes that do not involve overriding the default file directories.
  6. Apply the changes made to the library properties.
  7. When the 'Action Required' dialog appears, click "Save" This will save all changes, including those with invalid file directories for the second machine.
ss

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Renamed method to `promptUserToConfirmAction` to clarify its purpose
- Add localization for dialog messages
@paudelritij paudelritij marked this pull request as ready for review July 7, 2025 13:50
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 14, 2025
Siedlerchr
Siedlerchr previously approved these changes Jul 14, 2025
@trag-bot
Copy link

trag-bot bot commented Jul 14, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr added this pull request to the merge queue Jul 14, 2025
auto-merge was automatically disabled July 14, 2025 20:32

Pull Request is not mergeable

Merged via the queue into JabRef:main with commit 3e2e99a Jul 14, 2025
1 check passed
Siedlerchr added a commit that referenced this pull request Aug 2, 2025
* upstream/main:
  Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541)
  Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532)
  New Crowdin updates (#13548)
  Add focus to field Link in the "Add file link" dialog. (#13520)
  Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547)
  Make validation optional for saving library properties preferences (#13488)
  Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546)
  --porcelain does not output any info or warn errors on the console (#13469)
  Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545)
  Refine "File exists" warning (#13491)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544)
  Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542)
  Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540)
  Add architecture test for logging infrastructure (#13534)
  More harsh test on title of PR
  New Crowdin updates (#13533)
  Update extra-java-module-info plugin (#13527)
  [Junie]: fix: display help output for --help argument (#13446)
  Refactor OpenExternalFileAction  (#13508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add validations to file directories in library properties

3 participants