nhrpd: add cisco-authentication password support#16172
Merged
riw777 merged 2 commits intoFRRouting:masterfrom Jun 18, 2024
Merged
nhrpd: add cisco-authentication password support#16172riw777 merged 2 commits intoFRRouting:masterfrom
riw777 merged 2 commits intoFRRouting:masterfrom
Conversation
dleroy
force-pushed
the
dleroy/nhrpd-auth-support
branch
from
c473769 to
7a3e672
Compare
Member
|
A new issue poped up with this PR: https://ci1.netdef.org/browse/FRR-PULLREQ3-3588/artifact/ASAN3/AddressSanitizerError/AddressSanitzer.txt |
dleroy
force-pushed
the
dleroy/nhrpd-auth-support
branch
from
7a3e672 to
bb0fbf5
Compare
ton31337
reviewed
Jun 7, 2024
dleroy
force-pushed
the
dleroy/nhrpd-auth-support
branch
from
bb0fbf5 to
792d1dd
Compare
Implemented: - handling 8 char long password, aka Cisco style. - minimal error inidication routine - test case, password change affects conection Signed-off-by: Volodymyr Huti <v.huti@vyos.io>
Taking over this development from FRRouting#14788 This commit addresses 4 issues found in the previous PR 1) FRR would accept messages from a spoke without authentication when FRR NHRP had auth configured. 2) The error indication was not being sent in network byte order 3) The debug print in nhrp_connection_authorized was not correctly printing the received password 4) The addresses portion of the mandatory part of the error indication was invalid on the wire (confirmed in wireshark) Signed-off-by: Dave LeRoy <dleroy@labn.net> Co-authored-by: Volodymyr Huti <volodymyr.huti@gmail.com>
dleroy
force-pushed
the
dleroy/nhrpd-auth-support
branch
from
792d1dd to
b5540d3
Compare
riw777
reviewed
Jun 11, 2024
Member
riw777
left a comment
riw777
left a comment
There was a problem hiding this comment.
code looks okay, but the memory leak needs to be looked at before merging ...
Contributor
Author
I have addressed this issue and pushed fix. |
Contributor
Author
Hi Russ, I've addressed the address sanitizer failure. Is that what you were referring to? |
Open
Jafaral
added a commit
that referenced
this pull request
Nov 12, 2024
New Features Highlight: - PIM candidate BSR/RP [#16438] - Static IGMP join without an IGMP report [1#6450] - PIM AutoRP discovery/announcements [#16634] - IGMP proxy [#16861] - SRv6 SID Manager [#15604] - Add `bgp ipv6-auto-ra` command [#16354] - Implement `neighbor x remote-as auto` for BGP [#16345] - Implement `bgp dual-as` for BGP [#16816] - Implement BGP-wide configuration for graceful restart [#16099] - Handle kernel routes appropriately (should fix recent NOPREFIXROUTE issue) [#16300] - Add `cisco-authentication` password support for NHRP [#16172] Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes over work done on #14788 with agreement from @volodymyrhuti .
In addition to the work in 14788 I have addressed 4 issues I found while testing interop between Cisco and FRR: