Implement BGP-wide configuration for graceful restart by Pdoijode · Pull Request #16099 · FRRouting/frr

Pdoijode · 2024-05-28T18:37:19Z

Commit 1:
Add support for a BGP-wide setting for graceful restart modes and
parameters. This setting will apply to all BGP peers across all BGP
instances, but per-neighbor configuration can override it.
Per-instance configuration is disallowed if the BGP-wide setting
is in effect.

Commit2:
Streamline the BGP graceful-restart configuration at the global and
peer level some more. Similar to many other neighbor capability
parameters like MP and ENHE, reset the session immediately upon a
change to the configuration. This will be more aligned with the
transactional UI model also and will not require a separate 'clear'
command to be executed.

Note: Peer-group graceful-restart configuration is not yet supported.

Commit3:
bgpd: Refine restarter operation - R-bit & F-bit

Introduce BGP-wide flags to denote if BGP has started gracefully
and GR is in progress or not. Use this for setting of the R-bit in
the GR capability, and not a timer which is set for any new
instance creation. Mark graceful restart is complete when the
deferred path selection has been done and route sync with zebra as
well as deferred EOR advertisement has been initiated.

Introduce a function to check on F-bit setting rather than just
base it on configuration.

Subsequent commits will extend these functionalities.

Commit 4:
bgpd: Refine OPEN debug logs for graceful restart

This also fixes Rx F-bit log which was incorrect.

Pdoijode · 2024-05-28T22:04:43Z

ci:rerun

ton31337

Need a documentation update and topotests yet.

bgpd/bgp_fsm.c

bgpd/bgp_open.c

bgpd/bgp_route.c

bgpd/bgp_vty.c

bgpd/bgp_fsm.c

Pdoijode · 2024-05-29T21:34:40Z

Working on updating documentation and topotest.

Pdoijode · 2024-06-03T23:35:21Z

ci:rerun

ton31337 · 2024-06-10T11:26:49Z

This will be reviewed/merged after the stabilization branch is pulled (stable/10.1).

riw777

one small question, but code looks good

bgpd/bgp_fsm.c

ton31337 · 2024-06-25T11:51:37Z

Could you also rebase? It's quite too much behind the base.

Pdoijode · 2024-06-25T20:09:03Z

Added new commit: *: Add and use option for graceful (re)start

Pdoijode · 2024-06-27T15:56:31Z

ci:rerun

Pdoijode · 2024-06-27T18:36:22Z

@riw777, I have taken care of changes requested by @ton31337.

Add support for a BGP-wide setting for graceful restart modes and parameters. This setting will apply to all BGP peers across all BGP instances, but per-neighbor configuration can override it. Per-instance configuration is disallowed if the BGP-wide setting is in effect. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

Signed-off-by: Pooja Jagadeesh Doijode <pdoijode@nvidia.com>

Streamline the BGP graceful-restart configuration at the global and peer level some more. Similar to many other neighbor capability parameters like MP and ENHE, reset the session immediately upon a change to the configuration. This will be more aligned with the transactional UI model also and will not require a separate 'clear' command to be executed. Note: Peer-group graceful-restart configuration is not yet supported. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

Pdoijode · 2024-06-27T18:42:33Z

Rebased again with master

ton31337

I don't see --graceful_restart documented, or I'm blind?

Pdoijode · 2024-06-27T19:44:12Z

@ton31337, I have added documentation for newly introduced global commands here: ed1e90a. Other than these, no new commands were added and GR functionality hasn't changed. Let me know if I'm missing something.

ton31337 · 2024-06-27T19:58:19Z

@ton31337, I have added documentation for newly introduced global commands here: ed1e90a. Other than these, no new commands were added and GR functionality hasn't changed. Let me know if I'm missing something.

I meant -K isn't documented, is it?

Pdoijode · 2024-06-27T21:35:27Z

Wasn't aware that daemon options were also documented in .rst. Thanks for pointing it out. Updated documentation in 6f342c1

tests/topotests/bgp_gr_notification/test_bgp_gr_notification.py

ton31337

Please drop this commit and do the actual changes instead of back and forth. I'm about 555d8fc and d8b898f.

Introduce BGP-wide flags to denote if BGP has started gracefully and GR is in progress or not. Use this for setting of the R-bit in the GR capability, and not a timer which is set for any new instance creation. Mark graceful restart is complete when the deferred path selection has been done and route sync with zebra as well as deferred EOR advertisement has been initiated. Introduce a function to check on F-bit setting rather than just base it on configuration. Subsequent commits will extend these functionalities. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

This also fixes Rx F-bit log which was incorrect. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

Added topotest and documentation for BGP wide GR configurations Signed-off-by: Pooja Jagadeesh Doijode <pdoijode@nvidia.com>

Add a new start option "-K" to libfrr to denote a graceful start, and use it in zebra and bgpd. zebra will use this option to denote a planned FRR graceful restart (supporting only bgpd currently) to wait for a route sync completion from bgpd before cleaning up old stale routes from the FIB. An optional timer provides an upper-bounds for this cleanup. bgpd will use this option to denote either a planned FRR graceful restart or a bgpd-only graceful restart, and this will drive the BGP GR restarting router procedures. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

Pdoijode · 2024-07-02T04:04:18Z

ci:rerun

Pdoijode · 2024-07-02T11:34:52Z

Dropped 555d8fc and made the changes in d8b898f

ton31337

LGTM

New Features Highlight: - PIM candidate BSR/RP [#16438] - Static IGMP join without an IGMP report [1#6450] - PIM AutoRP discovery/announcements [#16634] - IGMP proxy [#16861] - SRv6 SID Manager [#15604] - Add `bgp ipv6-auto-ra` command [#16354] - Implement `neighbor x remote-as auto` for BGP [#16345] - Implement `bgp dual-as` for BGP [#16816] - Implement BGP-wide configuration for graceful restart [#16099] - Handle kernel routes appropriately (should fix recent NOPREFIXROUTE issue) [#16300] - Add `cisco-authentication` password support for NHRP [#16172] Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

frrbot bot added the bgp label May 28, 2024

github-actions bot added master size/XXL rebase PR needs rebase labels May 28, 2024

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from d962059 to 2165b33 Compare May 28, 2024 21:37

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 2 times, most recently from a0e03bd to 80d92e8 Compare May 28, 2024 22:44

ton31337 self-requested a review May 29, 2024 10:19

ton31337 requested changes May 29, 2024

View reviewed changes

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 2 times, most recently from 5825807 to dde73af Compare May 29, 2024 21:30

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from cb6b85a to 4456f95 Compare June 3, 2024 18:36

riw777 self-requested a review June 4, 2024 15:29

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 2 times, most recently from 0d7c60b to 4bbb1eb Compare June 5, 2024 18:14

riw777 reviewed Jun 11, 2024

View reviewed changes

bgpd/bgp_fsm.c Outdated Show resolved Hide resolved

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from 4bbb1eb to 85dc667 Compare June 24, 2024 22:36

frrbot bot added the tests Topotests, make check, etc label Jun 24, 2024

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 2 times, most recently from b6615f6 to e962370 Compare June 25, 2024 19:20

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 4 times, most recently from a93fed3 to 233a6eb Compare June 27, 2024 01:28

riw777 requested a review from ton31337 June 27, 2024 15:35

vivek-cumulus and others added 3 commits June 27, 2024 11:40

bgpd: Added ! after BGP global config

f0210cb

Signed-off-by: Pooja Jagadeesh Doijode <pdoijode@nvidia.com>

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from 233a6eb to 96633cd Compare June 27, 2024 18:41

ton31337 reviewed Jun 27, 2024

View reviewed changes

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from 96633cd to f2cb95c Compare June 27, 2024 21:32

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from f2cb95c to d8b898f Compare June 28, 2024 17:21

ton31337 reviewed Jun 30, 2024

View reviewed changes

tests/topotests/bgp_gr_notification/test_bgp_gr_notification.py Outdated Show resolved Hide resolved

ton31337 requested changes Jun 30, 2024

View reviewed changes

Pdoijode force-pushed the pdoijode/bgp-gr2 branch 2 times, most recently from 87a1bc6 to f7a73fa Compare July 1, 2024 19:39

vivek-cumulus and others added 6 commits July 1, 2024 13:02

bgpd: Refine OPEN debug logs for graceful restart

496b2d1

This also fixes Rx F-bit log which was incorrect. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

bgpd: Enhance OPEN Tx debug log

75040a0

Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

bgpd: Refine debug logs for zebra GR registration

c30b683

Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>

tests: Updated topotest and documentation

ecbca1a

Added topotest and documentation for BGP wide GR configurations Signed-off-by: Pooja Jagadeesh Doijode <pdoijode@nvidia.com>

Pdoijode force-pushed the pdoijode/bgp-gr2 branch from f7a73fa to b5682ff Compare July 1, 2024 20:04

ton31337 approved these changes Jul 2, 2024

View reviewed changes

ton31337 merged commit 9ab4186 into FRRouting:master Jul 2, 2024

Conversation

Pdoijode commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pdoijode commented May 28, 2024

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pdoijode commented May 29, 2024

Uh oh!

Pdoijode commented Jun 3, 2024

Uh oh!

ton31337 commented Jun 10, 2024

Uh oh!

riw777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ton31337 commented Jun 25, 2024

Uh oh!

Pdoijode commented Jun 25, 2024

Uh oh!

Pdoijode commented Jun 27, 2024

Uh oh!

Pdoijode commented Jun 27, 2024

Uh oh!

Pdoijode commented Jun 27, 2024

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Pdoijode commented Jun 27, 2024

Uh oh!

ton31337 commented Jun 27, 2024

Uh oh!

Pdoijode commented Jun 27, 2024

Uh oh!

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Pdoijode commented Jul 2, 2024

Uh oh!

Pdoijode commented Jul 2, 2024

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pdoijode commented May 28, 2024 •

edited

Loading