close #882 - fix gas free formular #899

PrometheusPi · 2015-06-01T09:59:59Z

This pull request solves issue #882:
It changes to interface from gasFreeFormular from cell offset back to position in SI units.

No examples are affected by this pull request.

gasConfig.param was changed for the reference file.

ax3l · 2015-06-01T17:17:32Z

great pull, thx!

is it possible to access cellSize inside the kernels? It might be necessary to calculate an offset in cells, e.g., for debugs or to load image/hdf5 data.

PrometheusPi · 2015-06-02T08:38:54Z

@ax3l no problem. @psychocoderHPC already asked for that too (in person). I will give make both available:

length in SI units
and cell position

even if they are related

PrometheusPi · 2015-06-02T10:57:06Z

@ax3l I made cellSize available in the functor, so that one can compute the cell position.

psychocoderHPC · 2015-06-03T15:00:26Z

src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp

cellSize is in PIConGPU units not in SI this might be confuse the user

PrometheusPi · 2015-06-03T15:25:28Z

@psychocoderHPC thanks for pointing this out - I fixed it.

PrometheusPi · 2015-06-11T15:43:16Z

@ax3l?

ax3l · 2015-06-17T08:25:05Z

src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp

pedantic: no space before ,

ax3l · 2015-06-17T08:27:35Z

@PrometheusPi very well done, thank you a bunch! the position and cell size now makes way more sense, I just found some very minor typos.

feel free to squash the commits afterward into two commits (e.g. for each file), no need to keep all 6.

PrometheusPi · 2015-06-23T11:20:04Z

fixed your typos (and rebased against dev - that's why all comits are reordered now)

ax3l · 2015-07-19T15:48:02Z

very well done, thank you!

close #882 - fix gas free formular

ax3l · 2015-07-29T14:58:58Z

I am not sure why I merged this, I am just spotting a few bugs ;) (will put them inline)

ax3l · 2015-07-29T15:01:12Z

src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp

cellSize_t is of type float_X and does not guarantee to hold a SI-scaled value.

PrometheusPi · 2015-07-29T15:02:37Z

I will take care of them.

ax3l · 2015-07-29T15:03:10Z

src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp

each component of position_SI is, as the DataSpace components, of type int which will not behave well when scaled to meters.

ax3l · 2015-07-29T15:08:53Z

I already prepared a pull, don't worry.

PrometheusPi · 2015-07-29T15:09:07Z

great

I overlooked a few types in ComputationalRadiationPhysics#899 (`dev` only) which should cause the `position_SI` argument always to be zero and the `cellSize_SI` argument to potentially overflow (or at least to loose precision). This commit fixes that.

c147cf1a5d hack for native clang usage for HIP ceead8c719 Merge pull request ComputationalRadiationPhysics#926 from psychocoderHPC/fix-implicitCAstWarning 86a8b8def8 test: fix implicit cast warning f90d1dc515 Merge pull request ComputationalRadiationPhysics#924 from BenjaminW3/topic-version-0.5 b1d2a8d866 Increase version to 0.5.0 167ca262f8 Merge pull request ComputationalRadiationPhysics#923 from BenjaminW3/topic-omp-num-threads-1 be8bf55791 Merge pull request ComputationalRadiationPhysics#920 from SimeonEhrig/bufferCopyComment 4162d26b61 Fix exception in TaskKernelCpuOmp2Blocks when OMP_NUM_THREADS==1 daffff6252 Add comment to pitch function at the bufferCopy example 284eef5113 Merge pull request ComputationalRadiationPhysics#916 from BenjaminW3/topic-gh-action 0a4969e5d0 Merge pull request ComputationalRadiationPhysics#917 from sbastrakov/doc-addBufferPinning 4924eb0bd6 Merge pull request ComputationalRadiationPhysics#918 from BenjaminW3/topic-remove-commented-out-sections fa2ce0ceef Add info on pinning to the CUDA mapping docs 68deac0768 Remove commented out code be64df2d29 Add automated gh-pages deployment for branch develop cb0e27819b Merge pull request ComputationalRadiationPhysics#915 from sbastrakov/topic-c++14HelperTypes adf11e573c Use C++ helper types for traits 8decb8d5b4 Merge pull request ComputationalRadiationPhysics#914 from sbastrakov/doc-addCuplaReference 9f528697f3 Merge pull request ComputationalRadiationPhysics#913 from sbastrakov/fix-ExampleCommentAcceleratorList 07e455b637 Add a reference to cupla to readme a06f345e7f Add forgotten TBB accelerator to the list in comments of the examples 432331fcc7 Merge pull request ComputationalRadiationPhysics#909 from BenjaminW3/topic-c++14-2 40bfeaaee7 Incorporate review comments 74e0ffa006 Remove meta::IntegerSequence 71afe1f0bb Remove unused includes 572777ed5a Remove unused TransformIntegerSequence e52b90d920 Remove unused meta::IndexSequence ed5b5f8d9b Prepare usage of std::integer_sequence aa0635525d Use std::integer_sequence instead of own IntegerSequence 6b914ca157 Use std::integer_sequence instead of own IntegerSequence for NdLoop 9811f23a30 Merge pull request ComputationalRadiationPhysics#910 from ax3l/topic-removeBetaStatusDev 9f3f01bb40 remove beta status b99acc704c Merge pull request ComputationalRadiationPhysics#907 from BenjaminW3/topic-integer_sequence b2db39d599 Merge pull request ComputationalRadiationPhysics#906 from BenjaminW3/topic-increase-min-boost 3992f097cf Raise minimum supported boost version from 1.62.0 to 1.65.1 53f74a28ee Merge pull request ComputationalRadiationPhysics#904 from BenjaminW3/topic-increase-min-ubuntu 1b346420de Replace alpaka::meta::IndexSequence with C++14 std::index_sequence 7180827504 Merge pull request ComputationalRadiationPhysics#900 from BenjaminW3/topic-c++14 be03160b3c Remove Support for ubuntu 14.04 bb3d6c49f0 Raise minimum to -std=c++14 and remove support for CUDA 8.0 and gcc 4.9 7910971a54 Merge pull request ComputationalRadiationPhysics#899 from BenjaminW3/topic-xcode-11_3 29234ffcc2 Add support for XCode 11.3 5135bdb27b Merge pull request ComputationalRadiationPhysics#901 from BenjaminW3/topic-fix-tbb-win-download bcd6d46ef6 Fix TBB installation REVERT: ab0b8a460f Merge pull request ComputationalRadiationPhysics#905 from psychocoderHPC/fix-tbb-win-download REVERT: d7471b9381 Merge pull request ComputationalRadiationPhysics#903 from psychocoderHPC/topic-removeBetaStatus REVERT: 13c06f9667 Fix TBB installation REVERT: ea6b56b0fb remove beta status git-subtree-dir: thirdParty/alpaka git-subtree-split: c147cf1a5d69e9f553986566a571298d92b856f5

48972eb593 hack for native clang usage for HIP 4eaff438cb Increase version to 0.5.0 b5f4402022 Fix exception in TaskKernelCpuOmp2Blocks when OMP_NUM_THREADS==1 7569489385 Add comment to pitch function at the bufferCopy example 0e1757dfff import ComputationalRadiationPhysics#864 b1042de4d3 HIP-clang support 284eef5113 Merge pull request ComputationalRadiationPhysics#916 from BenjaminW3/topic-gh-action 0a4969e5d0 Merge pull request ComputationalRadiationPhysics#917 from sbastrakov/doc-addBufferPinning 4924eb0bd6 Merge pull request ComputationalRadiationPhysics#918 from BenjaminW3/topic-remove-commented-out-sections fa2ce0ceef Add info on pinning to the CUDA mapping docs 68deac0768 Remove commented out code be64df2d29 Add automated gh-pages deployment for branch develop cb0e27819b Merge pull request ComputationalRadiationPhysics#915 from sbastrakov/topic-c++14HelperTypes adf11e573c Use C++ helper types for traits 8decb8d5b4 Merge pull request ComputationalRadiationPhysics#914 from sbastrakov/doc-addCuplaReference 9f528697f3 Merge pull request ComputationalRadiationPhysics#913 from sbastrakov/fix-ExampleCommentAcceleratorList 07e455b637 Add a reference to cupla to readme a06f345e7f Add forgotten TBB accelerator to the list in comments of the examples 432331fcc7 Merge pull request ComputationalRadiationPhysics#909 from BenjaminW3/topic-c++14-2 40bfeaaee7 Incorporate review comments 74e0ffa006 Remove meta::IntegerSequence 71afe1f0bb Remove unused includes 572777ed5a Remove unused TransformIntegerSequence e52b90d920 Remove unused meta::IndexSequence ed5b5f8d9b Prepare usage of std::integer_sequence aa0635525d Use std::integer_sequence instead of own IntegerSequence 6b914ca157 Use std::integer_sequence instead of own IntegerSequence for NdLoop 9811f23a30 Merge pull request ComputationalRadiationPhysics#910 from ax3l/topic-removeBetaStatusDev 9f3f01bb40 remove beta status b99acc704c Merge pull request ComputationalRadiationPhysics#907 from BenjaminW3/topic-integer_sequence b2db39d599 Merge pull request ComputationalRadiationPhysics#906 from BenjaminW3/topic-increase-min-boost 3992f097cf Raise minimum supported boost version from 1.62.0 to 1.65.1 53f74a28ee Merge pull request ComputationalRadiationPhysics#904 from BenjaminW3/topic-increase-min-ubuntu 1b346420de Replace alpaka::meta::IndexSequence with C++14 std::index_sequence 7180827504 Merge pull request ComputationalRadiationPhysics#900 from BenjaminW3/topic-c++14 be03160b3c Remove Support for ubuntu 14.04 bb3d6c49f0 Raise minimum to -std=c++14 and remove support for CUDA 8.0 and gcc 4.9 7910971a54 Merge pull request ComputationalRadiationPhysics#899 from BenjaminW3/topic-xcode-11_3 29234ffcc2 Add support for XCode 11.3 5135bdb27b Merge pull request ComputationalRadiationPhysics#901 from BenjaminW3/topic-fix-tbb-win-download bcd6d46ef6 Fix TBB installation REVERT: ab0b8a460f Merge pull request ComputationalRadiationPhysics#905 from psychocoderHPC/fix-tbb-win-download REVERT: d7471b9381 Merge pull request ComputationalRadiationPhysics#903 from psychocoderHPC/topic-removeBetaStatus REVERT: 13c06f9667 Fix TBB installation REVERT: ea6b56b0fb remove beta status git-subtree-dir: thirdParty/alpaka git-subtree-split: 48972eb59308971c29f1ee10aa374190c591c585

PrometheusPi added the refactoring code change to improve performance or to unify a concept but does not change public API label Jun 1, 2015

PrometheusPi added this to the Open Beta milestone Jun 1, 2015

PrometheusPi force-pushed the fix-gasFreeFormular branch 2 times, most recently from 0b19c41 to 6e4752c Compare June 1, 2015 10:54

ax3l self-assigned this Jun 1, 2015

psychocoderHPC reviewed Jun 3, 2015
View reviewed changes

ax3l reviewed Jun 17, 2015
View reviewed changes

src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp Outdated

Copy link

Member

ax3l Jun 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic: no space before ,

ax3l added the wait-4-author/WIP label Jun 17, 2015

PrometheusPi added 6 commits June 23, 2015 13:18

change cell_offset to SI position

351968d

adjust configuration to SI position

82d9938

make cellSize available in functor

610cd2e

add SI conform cellSize

f3ad3df

add documentation

4762440

fix typos as suggested by @ax3l

2b9d93d

PrometheusPi force-pushed the fix-gasFreeFormular branch from 77c58b6 to 2b9d93d Compare June 23, 2015 11:19

ax3l removed the wait-4-author/WIP label Jul 6, 2015

ax3l added a commit that referenced this pull request Jul 19, 2015

Merge pull request #899 from PrometheusPi/fix-gasFreeFormular

37b2be0

close #882 - fix gas free formular

ax3l merged commit 37b2be0 into ComputationalRadiationPhysics:dev Jul 19, 2015

PrometheusPi deleted the fix-gasFreeFormular branch July 27, 2015 14:05

ax3l reviewed Jul 29, 2015
View reviewed changes

ax3l mentioned this pull request Jul 29, 2015

Fix Gas Profile: Free Formula Types #976

Merged

close #882 - fix gas free formular #899

close #882 - fix gas free formular #899

Uh oh!

Conversation

PrometheusPi commented Jun 1, 2015

Uh oh!

ax3l commented Jun 1, 2015

Uh oh!

PrometheusPi commented Jun 2, 2015

Uh oh!

PrometheusPi commented Jun 2, 2015

Uh oh!

psychocoderHPC Jun 3, 2015

Choose a reason for hiding this comment

Uh oh!

PrometheusPi commented Jun 3, 2015

Uh oh!

PrometheusPi commented Jun 11, 2015

Uh oh!

ax3l Jun 17, 2015

Choose a reason for hiding this comment

Uh oh!

ax3l commented Jun 17, 2015

Uh oh!

PrometheusPi commented Jun 23, 2015

Uh oh!

ax3l commented Jul 19, 2015

Uh oh!

ax3l commented Jul 29, 2015

Uh oh!

ax3l Jul 29, 2015

Choose a reason for hiding this comment

Uh oh!

PrometheusPi commented Jul 29, 2015

Uh oh!

ax3l Jul 29, 2015

Choose a reason for hiding this comment

Uh oh!

ax3l commented Jul 29, 2015

Uh oh!

PrometheusPi commented Jul 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants