remove invalid typename keyword #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminW3
force-pushed
the
fix-invalid-typename
branch
from
af8c05c to
5cf7ef2
Compare
Member
|
@BenjaminW3 Why did you add WIP? What are you waiting for? |
Member
Author
|
I will remove some more typename declarations in upcoming commits. |
Member
There was a problem hiding this comment.
note for myself: would only be required if the types here would be templates for FieldB.
Member
|
looks good, let us just split the unitless & param changes in a second pull so I won't miss them in the change log |
BenjaminW3
force-pushed
the
fix-invalid-typename
branch
from
3f87b71 to
061f03e
Compare
Member
Author
|
The unitless and param changes have seperately been merged now. |
Member
|
thx, perfect! |
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Feb 20, 2020
c147cf1a5d hack for native clang usage for HIP ceead8c719 Merge pull request ComputationalRadiationPhysics#926 from psychocoderHPC/fix-implicitCAstWarning 86a8b8def8 test: fix implicit cast warning f90d1dc515 Merge pull request ComputationalRadiationPhysics#924 from BenjaminW3/topic-version-0.5 b1d2a8d866 Increase version to 0.5.0 167ca262f8 Merge pull request ComputationalRadiationPhysics#923 from BenjaminW3/topic-omp-num-threads-1 be8bf55791 Merge pull request ComputationalRadiationPhysics#920 from SimeonEhrig/bufferCopyComment 4162d26b61 Fix exception in TaskKernelCpuOmp2Blocks when OMP_NUM_THREADS==1 daffff6252 Add comment to pitch function at the bufferCopy example 284eef5113 Merge pull request ComputationalRadiationPhysics#916 from BenjaminW3/topic-gh-action 0a4969e5d0 Merge pull request ComputationalRadiationPhysics#917 from sbastrakov/doc-addBufferPinning 4924eb0bd6 Merge pull request ComputationalRadiationPhysics#918 from BenjaminW3/topic-remove-commented-out-sections fa2ce0ceef Add info on pinning to the CUDA mapping docs 68deac0768 Remove commented out code be64df2d29 Add automated gh-pages deployment for branch develop cb0e27819b Merge pull request ComputationalRadiationPhysics#915 from sbastrakov/topic-c++14HelperTypes adf11e573c Use C++ helper types for traits 8decb8d5b4 Merge pull request ComputationalRadiationPhysics#914 from sbastrakov/doc-addCuplaReference 9f528697f3 Merge pull request ComputationalRadiationPhysics#913 from sbastrakov/fix-ExampleCommentAcceleratorList 07e455b637 Add a reference to cupla to readme a06f345e7f Add forgotten TBB accelerator to the list in comments of the examples 432331fcc7 Merge pull request ComputationalRadiationPhysics#909 from BenjaminW3/topic-c++14-2 40bfeaaee7 Incorporate review comments 74e0ffa006 Remove meta::IntegerSequence 71afe1f0bb Remove unused includes 572777ed5a Remove unused TransformIntegerSequence e52b90d920 Remove unused meta::IndexSequence ed5b5f8d9b Prepare usage of std::integer_sequence aa0635525d Use std::integer_sequence instead of own IntegerSequence 6b914ca157 Use std::integer_sequence instead of own IntegerSequence for NdLoop 9811f23a30 Merge pull request ComputationalRadiationPhysics#910 from ax3l/topic-removeBetaStatusDev 9f3f01bb40 remove beta status b99acc704c Merge pull request ComputationalRadiationPhysics#907 from BenjaminW3/topic-integer_sequence b2db39d599 Merge pull request ComputationalRadiationPhysics#906 from BenjaminW3/topic-increase-min-boost 3992f097cf Raise minimum supported boost version from 1.62.0 to 1.65.1 53f74a28ee Merge pull request ComputationalRadiationPhysics#904 from BenjaminW3/topic-increase-min-ubuntu 1b346420de Replace alpaka::meta::IndexSequence with C++14 std::index_sequence 7180827504 Merge pull request ComputationalRadiationPhysics#900 from BenjaminW3/topic-c++14 be03160b3c Remove Support for ubuntu 14.04 bb3d6c49f0 Raise minimum to -std=c++14 and remove support for CUDA 8.0 and gcc 4.9 7910971a54 Merge pull request ComputationalRadiationPhysics#899 from BenjaminW3/topic-xcode-11_3 29234ffcc2 Add support for XCode 11.3 5135bdb27b Merge pull request ComputationalRadiationPhysics#901 from BenjaminW3/topic-fix-tbb-win-download bcd6d46ef6 Fix TBB installation REVERT: ab0b8a460f Merge pull request ComputationalRadiationPhysics#905 from psychocoderHPC/fix-tbb-win-download REVERT: d7471b9381 Merge pull request ComputationalRadiationPhysics#903 from psychocoderHPC/topic-removeBetaStatus REVERT: 13c06f9667 Fix TBB installation REVERT: ea6b56b0fb remove beta status git-subtree-dir: thirdParty/alpaka git-subtree-split: c147cf1a5d69e9f553986566a571298d92b856f5
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Feb 20, 2020
48972eb593 hack for native clang usage for HIP 4eaff438cb Increase version to 0.5.0 b5f4402022 Fix exception in TaskKernelCpuOmp2Blocks when OMP_NUM_THREADS==1 7569489385 Add comment to pitch function at the bufferCopy example 0e1757dfff import ComputationalRadiationPhysics#864 b1042de4d3 HIP-clang support 284eef5113 Merge pull request ComputationalRadiationPhysics#916 from BenjaminW3/topic-gh-action 0a4969e5d0 Merge pull request ComputationalRadiationPhysics#917 from sbastrakov/doc-addBufferPinning 4924eb0bd6 Merge pull request ComputationalRadiationPhysics#918 from BenjaminW3/topic-remove-commented-out-sections fa2ce0ceef Add info on pinning to the CUDA mapping docs 68deac0768 Remove commented out code be64df2d29 Add automated gh-pages deployment for branch develop cb0e27819b Merge pull request ComputationalRadiationPhysics#915 from sbastrakov/topic-c++14HelperTypes adf11e573c Use C++ helper types for traits 8decb8d5b4 Merge pull request ComputationalRadiationPhysics#914 from sbastrakov/doc-addCuplaReference 9f528697f3 Merge pull request ComputationalRadiationPhysics#913 from sbastrakov/fix-ExampleCommentAcceleratorList 07e455b637 Add a reference to cupla to readme a06f345e7f Add forgotten TBB accelerator to the list in comments of the examples 432331fcc7 Merge pull request ComputationalRadiationPhysics#909 from BenjaminW3/topic-c++14-2 40bfeaaee7 Incorporate review comments 74e0ffa006 Remove meta::IntegerSequence 71afe1f0bb Remove unused includes 572777ed5a Remove unused TransformIntegerSequence e52b90d920 Remove unused meta::IndexSequence ed5b5f8d9b Prepare usage of std::integer_sequence aa0635525d Use std::integer_sequence instead of own IntegerSequence 6b914ca157 Use std::integer_sequence instead of own IntegerSequence for NdLoop 9811f23a30 Merge pull request ComputationalRadiationPhysics#910 from ax3l/topic-removeBetaStatusDev 9f3f01bb40 remove beta status b99acc704c Merge pull request ComputationalRadiationPhysics#907 from BenjaminW3/topic-integer_sequence b2db39d599 Merge pull request ComputationalRadiationPhysics#906 from BenjaminW3/topic-increase-min-boost 3992f097cf Raise minimum supported boost version from 1.62.0 to 1.65.1 53f74a28ee Merge pull request ComputationalRadiationPhysics#904 from BenjaminW3/topic-increase-min-ubuntu 1b346420de Replace alpaka::meta::IndexSequence with C++14 std::index_sequence 7180827504 Merge pull request ComputationalRadiationPhysics#900 from BenjaminW3/topic-c++14 be03160b3c Remove Support for ubuntu 14.04 bb3d6c49f0 Raise minimum to -std=c++14 and remove support for CUDA 8.0 and gcc 4.9 7910971a54 Merge pull request ComputationalRadiationPhysics#899 from BenjaminW3/topic-xcode-11_3 29234ffcc2 Add support for XCode 11.3 5135bdb27b Merge pull request ComputationalRadiationPhysics#901 from BenjaminW3/topic-fix-tbb-win-download bcd6d46ef6 Fix TBB installation REVERT: ab0b8a460f Merge pull request ComputationalRadiationPhysics#905 from psychocoderHPC/fix-tbb-win-download REVERT: d7471b9381 Merge pull request ComputationalRadiationPhysics#903 from psychocoderHPC/topic-removeBetaStatus REVERT: 13c06f9667 Fix TBB installation REVERT: ea6b56b0fb remove beta status git-subtree-dir: thirdParty/alpaka git-subtree-split: 48972eb59308971c29f1ee10aa374190c591c585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typenamecannot be used outside a template declaration.Only gcc allows this code in c++98. Clang correctly rejects this as it is only allowed in c++11.