Fix Gas Profile: Free Formula Types #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
force-pushed
the
fix-gasFreeFormulaTypes
branch
from
91d504a to
474de77
Compare
Member
|
@ax3l: please add your name to the license header of |
ax3l
force-pushed
the
fix-gasFreeFormulaTypes
branch
2 times, most recently
from
ce568d2 to
deef745
Compare
I overlooked a few types in ComputationalRadiationPhysics#899 (`dev` only) which should cause the `position_SI` argument always to be zero and the `cellSize_SI` argument to potentially overflow (or at least to loose precision). This commit fixes that.
ax3l
force-pushed
the
fix-gasFreeFormulaTypes
branch
from
deef745 to
1fc8f43
Compare
ax3l
force-pushed
the
fix-gasFreeFormulaTypes
branch
from
1fc8f43 to
de6f158
Compare
Member
Author
|
updated and pushed :) |
Member
Author
|
@PrometheusPi merg-able :) |
PrometheusPi
added a commit
that referenced
this pull request
Jul 30, 2015
Fix Gas Profile: Free Formula Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overlooked a few types in #899 (
devonly) which should cause theposition_SIargument always tobe zero and the
cellSize_SIargument to potentially overflow (or at least to loose precision).This pull request fixes that.