HDF5 WriteField: Fix Wrong Doc String and Index#690
Merged
psychocoderHPC merged 1 commit intoFeb 12, 2015
Merged
Conversation
ax3l
added
documentation
Member
Author
|
review note: this pull request does only fix mixed and weird variable namings and a wrong comment and is therefore not related to #689 (which allows easier backporting of the critical bug therein). Nevertheless, please take very good care with this pull since it is a bit tricky to read. |
ax3l
force-pushed
the
topic-hdf5VarsWriteField
branch
2 times, most recently
from
f63b49f to
6044476
Compare
the index names in `hdf5/writer/Field.hpp` are not ideal (even if the implementation is correct): once `d` is used as an index `[0; simDim]` and once as an index `[0; nComponents]` and same mixed with `i`. we now use `n` consequently for vector components (x, y, z and w) of fields and `d` for *spatial* counts from `0` to `simDim`. `i` is still used if we iterate over linear memory.
Member
|
Should it be that the ranges in your description are wrong and must be: |
Member
Author
|
updated, thanks. |
psychocoderHPC
added a commit
that referenced
this pull request
Feb 12, 2015
HDF5 WriteField: Fix Wrong Doc String and Index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the index names in
hdf5/writer/Field.hppare not ideal (even if the implementation is correct): oncedis used as an index[0; simDim-1]and once as an index[0; nComponents-1]and same mixed withi.we now use
nconsequently for vector components (x, y, z and w) of fields anddfor spatial counts from0tosimDim-1.iis only used if we iterate over linear memory.