Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Feb 10, 2015

Fix #688 2D Restart Fields: in 2D simulations, the last component (z) of FieldE and FieldB was not initialized again (default: zero).

  • verify with 2D KHI simulation and check EnergyFields.dat before/after restart (especially B_z)

unrelated:

the index names in hdf5/writer/Field.hpp are not ideal (even if the implementation is correct): once d is used as an index [0; simDim-1] and once as an index [0; nComponents-1] and same mixed with i.

@ax3l ax3l added component: plugin in PIConGPU plugin need-info/blocked bug a bug in the project's code affects latest release a bug that affects the latest stable release labels Feb 10, 2015
@ax3l ax3l added this to the Open Beta milestone Feb 10, 2015
@ax3l ax3l force-pushed the fix-hdf52Drestart branch 4 times, most recently from 0890ebf to 248971a Compare February 10, 2015 23:52
@ax3l ax3l force-pushed the fix-hdf52Drestart branch from 248971a to 1fe433c Compare February 11, 2015 10:09
- in 2D simulations, the last component (z) of FieldE and FieldB
  was not initialized again (default: zero)
@PrometheusPi PrometheusPi self-assigned this Feb 11, 2015
@PrometheusPi
Copy link
Member

I will test this with KHI 2D restart.

@ax3l
Copy link
Member Author

ax3l commented Feb 11, 2015

ok cool.
I suggest running until step 1000 with dumping energy_fields every 10 steps.
then two restart(s): one with old version and one with fixed.

The plot of Energy B_z would be interesting for both restarts.

@PrometheusPi
Copy link
Member

I ran the simulation (KHI, 2D, electron/positron, total of 2000 time steps, restart after 1000th time step)

The numerical heating shows that the fix worsens the numerical heating 😜.
numericalheating
Since we loose energy with the restart, we counteract the numerical heating.

If we have a look at the energy stored in the driving magnetic field B_z:
bz
we see a clear reaction to the restart error. The feedback loop misses one compenent and restarts iteslf. We see strong oscilation untill the error is compensated. B_z is now higher but we lost more energy in the electrons and the other field components.

The total field energy looks similar:
fields

PrometheusPi added a commit that referenced this pull request Feb 12, 2015
Fix #688 2D Restart Fields
:+1: Great job @ax3l .
@PrometheusPi PrometheusPi merged commit a52dc9b into ComputationalRadiationPhysics:dev Feb 12, 2015
@ax3l ax3l deleted the fix-hdf52Drestart branch February 12, 2015 14:13
@ax3l
Copy link
Member Author

ax3l commented Feb 12, 2015

thank you for running the tests on taurus, holy moly - what a bug.

@PrometheusPi
Copy link
Member

No problem. I used hypnos/k20d not taurus/gpu.

@ax3l
Copy link
Member Author

ax3l commented Feb 12, 2015

oh! good catch! I want that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants