Clam 2269 & 2271: CDIFF: unlink, close issues. Freshclam: download whole CVD if failure applying CDIFF#893
Conversation
In the event that there is an issue with the CDIFF process, freshclam is treating it as thought no patch was downloaded. If freshclam fails to apply the patch because of an issue with the patch, or some bug in the CDIFF module, it should retry for the whole CVD.
|
Code looks good to me, however tests 8 and 9 fail when I run ctest. |
OH NO! How'd I miss that? Will look into it and get back to you. |
val-ms
changed the title
|
Okay I think it's all fixed and ready for review. I found a couple extra issues when investigating. The main other issue is this. It turns out the reason my original fix didn't work is because it did work and in so doing, it exposed a bug. It turns out the tests that apply I also fixed some bad log messages and improved some other log messages. I've also merged the fixes from #892 into this PR because a moment I thought at first that the unlink bug was the cause of the CDIFF failures. It makes sense though in the end because I've had to add the CDIFF CLOSE operation fix so may as well do it in the PR that adds the CDIFF UNLINK operation fix. |
shutton
left a comment
shutton
left a comment
There was a problem hiding this comment.
Changes as discussed live.
Also includes: - A sigtool test to verify that Rust log macros are working. - Changing the freshclam tests to use --no-dns so they run faster when DNS isn't working (e.g. no internet).
Some log statements using the old ^, !, and * logg-prefix where they
were making use a ternary to determine the log level in the log
statement.
Also sigtool and freshclam weren't outputting error log messages using
the Rust log macros e.g. `error!("...")`.
Any cdiff or script using the UNLINK operation will fail to delete the file claiming "No DB open for action UNLINK". The UNLINK operation appears to be trying to delete a currently open database, when in fact it should ensure no database is open before deleting the local file given by the single "db_name" parameter.
val-ms
force-pushed
the
CLAM-2271-cdiff-apply-failure
branch
from
9527bba to
9e24c27
Compare
shutton
left a comment
shutton
left a comment
There was a problem hiding this comment.
Just that one utf8 conversion issue
The CLOSE command is failing to create a file when appending changes if the file does not already exist. This prevents adding new files to a database with a CDIFF and caused failures applying the test-3.cdiff file in the freshclam feature tests. Also improved the error message to show which command, specifically, is failing (not just the line number).
val-ms
force-pushed
the
CLAM-2271-cdiff-apply-failure
branch
2 times, most recently
from
1e579fa to
e8103c1
Compare
val-ms
force-pushed
the
CLAM-2271-cdiff-apply-failure
branch
from
e8103c1 to
5c9bca0
Compare
|
Just fixed some python 3.5 compatibility issues because python 3.6 isn't available on all machines we test on, even though python 3.5 is past enough of life. Sigh. Anyways all looked good now in the test pipeline. Will merge. |
val-ms
added
the
🍒cherry-pick-candidate
3 participants
In the event that there is an issue with the CDIFF process, freshclam is treating it as thought no patch was downloaded.
If freshclam fails to apply the patch because of an issue with the patch, or some bug in the CDIFF module, it should retry for the whole CVD.