Closed
Conversation
Any cdiff or script using the UNLINK operation will fail to delete the file claiming "No DB open for action UNLINK". The UNLINK operation appears to be trying to delete a currently open database, when in fact it should ensure no database is open before deleting the local file given by the single "db_name" parameter.
Contributor
Author
|
Moved commits from this over to #893 because there were some additional related bugs discovered when working on that and it made sense to fix everything in one PR to get all the tests to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue applying cdiffs that unlink a file (e.g. dropping a CBC signature from bytecode.cvd).
Also some minor code cleanup to resolve linter errors.