Clam 2269 2271 cdiff issues 0.105#902
Closed
val-ms wants to merge 7 commits intoCisco-Talos:dev/0.105.3from
Closed
Clam 2269 2271 cdiff issues 0.105#902val-ms wants to merge 7 commits intoCisco-Talos:dev/0.105.3from
val-ms wants to merge 7 commits intoCisco-Talos:dev/0.105.3from
Conversation
In the event that there is an issue with the CDIFF process, freshclam is treating it as thought no patch was downloaded. If freshclam fails to apply the patch because of an issue with the patch, or some bug in the CDIFF module, it should retry for the whole CVD.
Also includes: - A sigtool test to verify that Rust log macros are working. - Changing the freshclam tests to use --no-dns so they run faster when DNS isn't working (e.g. no internet).
Some log statements using the old ^, !, and * logg-prefix where they
were making use a ternary to determine the log level in the log
statement.
Also sigtool and freshclam weren't outputting error log messages using
the Rust log macros e.g. `error!("...")`.
Any cdiff or script using the UNLINK operation will fail to delete the file claiming "No DB open for action UNLINK". The UNLINK operation appears to be trying to delete a currently open database, when in fact it should ensure no database is open before deleting the local file given by the single "db_name" parameter.
The CLOSE command is failing to create a file when appending changes if the file does not already exist. This prevents adding new files to a database with a CDIFF and caused failures applying the test-3.cdiff file in the freshclam feature tests. Also improved the error message to show which command, specifically, is failing (not just the line number).
Contributor
Author
|
Oops! Nevermind. Publishing 1.1 means that 0.105 is past end of life for new patch versions as per the EOL policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #893 for 0.105