sonic-utils: initial support for link-training by ds952811 · Pull Request #2071 · sonic-net/sonic-utilities

ds952811 · 2022-02-16T11:58:22Z

HLD: sonic-net/SONiC#925

What I did

Add CLI support for link-trainig

How I did it

portconfig: initial support for link-training config
config/main.py: initial support for link-training config
intfutil: initial support for link-training show command
show/interfaces/init.py: initial support for link-training show command

How to verify it

Manual test
Ran the Unit-tests to the corresponding changes

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo config interface link-training Ethernet0 on
admin@sonic:~$ sudo config interface link-training Ethernet8 on
admin@sonic:~$ sudo config interface link-training Ethernet16 off
admin@sonic:~$ sudo config interface link-training Ethernet24 on
admin@sonic:~$ sudo config interface link-training Ethernet32 off
admin@sonic:~$ show interfaces link-training status
  Interface      LT Oper    LT Admin    Oper    Admin
-----------  -----------  ----------  ------  -------
  Ethernet0      trained          on      up       up
  Ethernet8      trained          on      up       up
 Ethernet16          off         off    down       up
 Ethernet24  not trained          on    down       up
 Ethernet32          off         off    down       up
 Ethernet40          off           -    down       up
 Ethernet48          off           -    down       up
 Ethernet56          off           -    down       up
 Ethernet64          off           -    down       up
 Ethernet72          off           -    down       up
 Ethernet80          off           -    down       up
 Ethernet88          off           -    down       up
 Ethernet96          off           -    down       up
Ethernet104          off           -    down       up
Ethernet112          off           -    down       up
Ethernet120          off           -    down       up
Ethernet128          off           -    down       up
Ethernet136          off           -    down       up
Ethernet144          off           -    down       up
Ethernet152          off           -    down       up
Ethernet160          off           -    down       up
Ethernet168          off           -    down       up
Ethernet176          off           -    down       up
Ethernet184          off           -    down       up
Ethernet192          off           -    down       up
Ethernet200          off           -    down       up
Ethernet208          off           -    down       up
Ethernet216          off           -    down       up
Ethernet224          off           -    down       up
Ethernet232          off           -    down       up
Ethernet240          off           -    down       up
Ethernet248          off           -    down       up
admin@sonic:~$

lgtm-com · 2022-02-16T12:07:47Z

This pull request introduces 3 alerts when merging 65e43cd into 9e50124 - view on LGTM.com

new alerts:

3 for Unused import

lgtm-com · 2022-03-24T07:26:19Z

This pull request introduces 2 alerts when merging 188c561 into f71ef64 - view on LGTM.com

new alerts:

2 for Unused import

dgsudharsan · 2022-04-01T04:21:59Z

config/main.py

+@click.argument('mode', metavar='<mode>', required=True, type=click.Choice(["on", "off"]))
+@click.option('-v', '--verbose', is_flag=True, help="Enable verbose output")
+def link_training(ctx, interface_name, mode, verbose):
+    """Set interface auto negotiation mode"""


Typo. Should be link training instead of auto negotiation

dgsudharsan · 2022-04-21T01:56:26Z

The changes look good to me. Can you please resolve the conflicts? I will approve once the conflicts are resolved

Junchao-Mellanox · 2022-04-21T02:15:25Z

scripts/portconfig

+        if self.verbose:
+            print("Setting link-training %s on port %s" % (mode, port))
+        if mode not in ['on', 'off']:
+            mode = 'off'


Maybe print an error and exit?

Noted, and it's done

adyeung · 2022-05-05T21:18:00Z

@zhangyanzhao @yxieca pls help signoff and merge

- What I did Add CLI support for link-trainig - How I did it portconfig: initial support for link-training config config/main.py: initial support for link-training config intfutil: initial support for link-training show command show/interfaces/init.py: initial support for link-training show command - How to verify it Manual test Ran the Unit-tests to the corresponding changes Signed-off-by: Dante Su <[email protected]>

Signed-off-by: Dante Su <[email protected]>

qiluo-msft · 2022-05-16T02:20:16Z

show/interfaces/__init__.py

    clicommon.run_command(cmd, display_cmd=verbose)
+
+#
+# link-training group (show interfaces link-training ...)


show interfaces

Is there a reason to choose show interfaces vs show interface? #Closed

I have no idea, this is a legacy command, and my best guess is that it supports both signle interface and multi-interface at the same time, hence the original author adopted 'show interfaces' instead of 'show interface'

Could you fix the PR description? I see many wrong subcommand.

sudo config interface link-training Ethernet0 on

Sorry, I'm not following you, is this about 'interfaces' v.s. 'interface' in show and config command?
If that's the case, this is a legacy command format since day 1, while the link-training is actually a plug-in to these legacy CLICK based CLI commands, hence it's not expected to change the upper level command syntax.

Got it. I see the difference between show and config.

Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <[email protected]>

Blueve · 2022-07-07T06:09:19Z

@ds952811 can you help update CLI doc as well?

ds952811 · 2022-07-07T07:15:39Z

@ds952811 can you help update CLI doc as well?

Done, it's now available in PR #2257

HLD: sonic-net/SONiC#925 #### What I did Add CLI support for link-trainig #### How I did it 1. portconfig: initial support for link-training config 2. config/main.py: initial support for link-training config 3. intfutil: initial support for link-training show command 4. show/interfaces/__init__.py: initial support for link-training show command #### How to verify it 1. Manual test 2. Ran the Unit-tests to the corresponding changes #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed) ``` admin@sonic:~$ sudo config interface link-training Ethernet0 on admin@sonic:~$ sudo config interface link-training Ethernet8 on admin@sonic:~$ sudo config interface link-training Ethernet16 off admin@sonic:~$ sudo config interface link-training Ethernet24 on admin@sonic:~$ sudo config interface link-training Ethernet32 off admin@sonic:~$ show interfaces link-training status Interface LT Oper LT Admin Oper Admin ----------- ----------- ---------- ------ ------- Ethernet0 trained on up up Ethernet8 trained on up up Ethernet16 off off down up Ethernet24 not trained on down up Ethernet32 off off down up Ethernet40 off - down up Ethernet48 off - down up Ethernet56 off - down up Ethernet64 off - down up Ethernet72 off - down up Ethernet80 off - down up Ethernet88 off - down up Ethernet96 off - down up Ethernet104 off - down up Ethernet112 off - down up Ethernet120 off - down up Ethernet128 off - down up Ethernet136 off - down up Ethernet144 off - down up Ethernet152 off - down up Ethernet160 off - down up Ethernet168 off - down up Ethernet176 off - down up Ethernet184 off - down up Ethernet192 off - down up Ethernet200 off - down up Ethernet208 off - down up Ethernet216 off - down up Ethernet224 off - down up Ethernet232 off - down up Ethernet240 off - down up Ethernet248 off - down up admin@sonic:~$ ```

Update sonic-utilities submodule pointer to include the following: * Fix test failure in dump table test in 202205 ([sonic-net#2307](sonic-net/sonic-utilities#2307)) * Convert IPv6 addresses to lowercase in apply-patch ([sonic-net#2299](sonic-net/sonic-utilities#2299)) * [config][muxcable] add support to enable/disable ycable telemetry ([sonic-net#2297](sonic-net/sonic-utilities#2297)) * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * Support to enable fips for the command sonic_installer (sonic-net#2154) ([sonic-net#2303](sonic-net/sonic-utilities#2303)) Signed-off-by: dprital <[email protected]>

ds952811 mentioned this pull request Feb 18, 2022

[link-training] initial support sonic-net/SONiC#925

Merged

ds952811 force-pushed the link-training branch from 65e43cd to 188c561 Compare March 24, 2022 07:17

dgsudharsan requested a review from Junchao-Mellanox April 1, 2022 03:49

dgsudharsan requested changes Apr 1, 2022

View reviewed changes

ds952811 force-pushed the link-training branch from d9afa97 to 1e6a0a9 Compare April 13, 2022 04:18

Junchao-Mellanox requested changes Apr 21, 2022

View reviewed changes

ds952811 force-pushed the link-training branch from c5cf7af to 628f68b Compare April 22, 2022 02:29

Junchao-Mellanox previously approved these changes Apr 22, 2022

View reviewed changes

dgsudharsan previously approved these changes Apr 29, 2022

View reviewed changes

ds952811 dismissed stale reviews from dgsudharsan and Junchao-Mellanox via 8091c9e May 11, 2022 03:12

ds952811 force-pushed the link-training branch from 45c4af6 to 8091c9e Compare May 11, 2022 03:12

ds952811 added 5 commits May 11, 2022 03:18

address the test failures

393c7c9

Signed-off-by: Dante Su <[email protected]>

address the test failures in intfutil_test.py

4643e75

Signed-off-by: Dante Su <[email protected]>

drop LINK_TRAINING and typo fix

5903101

Signed-off-by: Dante Su <[email protected]>

error out when invalid LT mode is specified

6665a62

Signed-off-by: Dante Su <[email protected]>

ds952811 force-pushed the link-training branch from 8091c9e to 6665a62 Compare May 11, 2022 03:26

dgsudharsan approved these changes May 11, 2022

View reviewed changes

Junchao-Mellanox approved these changes May 12, 2022

View reviewed changes

qiluo-msft reviewed May 16, 2022

View reviewed changes

qiluo-msft approved these changes May 18, 2022

View reviewed changes

qiluo-msft merged commit 88286cb into sonic-net:master May 18, 2022

dprital mentioned this pull request May 25, 2022

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#10928

Closed

6 tasks

Blueve mentioned this pull request Jul 6, 2022

Test AN/LT behavior sonic-net/sonic-mgmt#5798

Open

liat-grozovik added the Request for 202205 Branch label Aug 11, 2022

yxieca added the Included in 202205 Branch label Aug 11, 2022

dprital mentioned this pull request Aug 12, 2022

[202205][submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#11721

Closed

7 tasks

Conversation

ds952811 commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

lgtm-com bot commented Feb 16, 2022

Uh oh!

lgtm-com bot commented Mar 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgsudharsan commented Apr 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adyeung commented May 5, 2022

Uh oh!

qiluo-msft May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Blueve commented Jul 7, 2022

Uh oh!

ds952811 commented Jul 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ds952811 commented Feb 16, 2022 •

edited

Loading

qiluo-msft May 16, 2022 •

edited

Loading