Speed up and fix parsing errors #53
Conversation
compliant with atom-linter fields - consume data faster by interfacing directly with BufferedNodeProcess - attempt to kill htmlhint process if pane is destroyed
There was a problem hiding this comment.
Let's not change to a different htmlhint. Add your custom changes directly to htmlhint. htmlhint moves pretty fast, I'd like to stay on the main repo.
|
@admosity Are you still planning on working on this? I'm rather against a custom fork as well unless absolutely necessary. |
|
@Arcanemagus I'm super swamped, otherwise I would. I also don't quite know a good way to go about doing this since the issue comes from atom's BufferedReader truncating input when it detects the subprocess exiting. HTMLHint itself uses |
|
Closing this in favor of #112, which moves to using the Node API on the official repo. Thanks for putting the work into this though! |
3 participants
Don't know if I'm committing blasphemy, but I'm loading up a slightly custom version of htmlhint that spits out atom-linter compliant objects and has fixes for #50 and #45. I might be doing something wrong with killing the last running htmlhint process.