No subprocess

[download13]

Instead of running htmlhint as a subprocess, import and call it directly with the buffer contents. This enables lintOnFly.

Solves #111

[Arcanemagus]

If possible these modules should be lazily loaded, I've used lazy-req in the past, but if you have a better method go for it 😉.

Right now this will increase the package loading time as these will be required on Atom launch.

(This comment goes for all the imports.)

[download13]

I changed out all the imports for require calls in the places where they are needed. It looks a little odd, but it shaved about 20-30ms off the load time.

[download13]

Whoops. I responded to your comments but then they disappeared when I pushed the new commit.
Is that supposed to happen? Should I reply in this main thread thing?

[download13]

Should I change anything else? Is there someone who needs to look this over before it can be merged?

[Arcanemagus]

Comments on a specific line of code are collapsed when the underlying code in a PR is updated to make the comment no longer relevant to that line of code. It's a nice feature of GitHub so when fixes/changes are made to the code the comments that are (most likely) no longer relevant are hidden unless somebody explicitly looks for them.

[Arcanemagus]

No need for this line.

[Arcanemagus]

So the point I was trying to make with the lazy-req reference wasn't just to move the require calls around. The way it is now does move the load away from the package load time, but now the lints themselves will be longer, and we are relying on require to cache loads, which isn't always the case. With something like lazy-req the first use is just as painful as a regular require, but subsequent uses are guaranteed to be cached. The only issue I have with it is most things are turned into a function call which makes the code look a bit odd, but it works.

Since Atom is usually pretty good about caching require calls I'd be fine with merging this as is, after the above comment is addressed. Unless there is something else you want changed @johnwebbcole?

[johnwebbcole]

I'm ok with it

[download13]

When does require not cache loads? I thought it cached everything unless something explicitly deleted it's cache.

[download13]

So it's ready to merge? Nothing else to do?

[Arcanemagus]

Sorry, this must have gotten lost in my notifications 😞. Taking one more look over this and then merging.

[Arcanemagus]

Published as v1.2.0, thanks again! 🎉