Unexpected end of file

[rugk]

This error was showed after I created a HTML file with markdown-preview.

SyntaxError: Unexpected end of input
  at Object.parse (native)
  at D:\Users\%username%\.atom\packages\linter-htmlhint\lib\init.coffee:41:32
  at process._tickCallback (node.js:365:9)

Atom 1.1.0
Windows 7

[ianmustafa]

Same here, but with PHP file.
Atom 1.2.0 on OS X El Capitan 10.11.1
linter-htmlhint 0.2.1

[abraham]

Getting these errors stacking endlessly on an erb file. Had to disable the package to get any work done.

[johnwebbcole]

Could you post a short example. I can't get any samples to throw the same error.

[abraham]

I was just digging around and the response from /Users/abraham/.atom/packages/linter-htmlhint/node_modules/htmlhint/bin/htmlhint contains unescaped \n instead of escaped \\n sometimes. This was causing L41 to blow up.

[johnwebbcole]

Good catch! Do you have enough info to open a ticket on htmlhint? If not, I'll try and replicate it too.

[abraham]

I have a snippet of code that I can't share but I'll try and get a sharable repo snippet later today.

[rugk]

Could you post a short example.

In my test it works with every file produced by markdown-preview.

[abraham]

This triggers the error for me consistently. It looks like it's not actually an issue with not escaping newlines but instead is an issue with the response getting cropped somewhere.

test.html.erb

<% if @people.length == 0 %>
<% else %>
  <% @people.each do |p| %>
    <% p.contacts.each do |c| %>
      <tr class="<%= cycle("white", "shaded") %>"></tr>
    <% end %>
  <% end %>
<% end %>

This is what output is at L41 and you can see the end of it does not close up the JSON properly.

"[{"file":"/Users/abraham/dev/sandbox/test.html.erb","messages":[{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"<% if @people.length == 0 %>","line":1,"col":1,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"<% if @people.length == 0 %>","line":1,"col":28,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"<% else %>","line":2,"col":1,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"<% else %>","line":2,"col":10,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"  <% @people.each do |p| %>","line":3,"col":3,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"  <% @people.each do |p| %>","line":3,"col":27,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"    <% p.contacts.each do |c| %>","line":4,"col":5,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"    <% p.contacts.each do |c| %>","line":4,"col":32,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\"></tr>","line":5,"col":7,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\"></tr>","line":5,"col":18,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\"></tr>","line":5,"col":48,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\"></tr>","line":5,"col":50,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Doctype must be declared first.","raw":"<% if @people.length == 0 %>\n<% else %>\n  <% @people.each do |p| %>\n    <% p.contacts.each do |c| %>\n      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\">","evidence":"<% if @people.length == 0 %>","line":1,"col":1,"rule":{"id":"doctype-first","description":"Doctype must be declared first.","link":"https://github.com/yaniswang/HTMLHint/wiki/doctype-first"}},{"type":"error","message":"Tag must be paired, no start tag: [ </tr> ]","raw":"</tr>","evidence":"      <tr class=\"<%= cycle(\"white\", \"shaded\") %>\"></tr>","line":5,"col":51,"rule":{"id":"tag-pair","description":"Tag must be paired.","link":"https://github.com/yaniswang/HTMLHint/wiki/tag-pair"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"    <% end %>","line":6,"col":5,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"    <% end %>","line":6,"col":13,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"  <% end %>","line":7,"col":3,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"  <% end %>","line":7,"col":11,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ < ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"<% end %>","line":8,"col":1,"rule":{"id":"spec-char-escape","description":"Special characters must be escaped.","link":"https://github.com/yaniswang/HTMLHint/wiki/spec-char-escape"}},{"type":"error","message":"Special characters must be escaped : [ > ].","raw":"\n    <% end %>\n  <% end %>\n<% end %>\n","evidence":"<% end %>","line":8,"col":9,"rule":{"id":"spec-char-escape","description":"Spe"

Running /Users/abraham/.atom/packages/linter-htmlhint/node_modules/htmlhint/bin/htmlhint test.html.erb --format json | jq in the terminal results in a complete JSON result so it doesn't appear to be an issue with HTMLHint.

[johnwebbcole]

Yep, that threw an error for me too. Thx! I'll look at it.

[abraham]

Digging around a little more it seems like the BufferedNodeProcess stdout callback is getting the encoded JSON already truncated in helpers.coffee.

[rugk]

FYI this also happens when I create a completely empty file.
I created a index.htm file in a folder using the Atom treeview and directly after the file was opened these two errors were thrown:

And they also show up when I type any character afterwards or save the file (where only the first error pops up).

[admosity]

Should've looked this up first hah. I believe @abraham is right. I think process.exit is being triggered before the process has finished writing to stdout. BufferedNodeProcess listens for the exit event from the process. Despite there being more to capture, it stops it there and concats the input.

I've created a pull request in htmlhint to make sure stdout has been drained before exiting, but I'm about to close that because he moved over to streams for the formatters and my solution isn't going to work in that version need more coffee.

So here's a gist instead of my fix of the current htmlhint version that I installed from npm (version 0.9.12).
https://gist.github.com/admosity/f34bb48ed859571b6533

Specifically for the json formatter it checks if the write completed.

Changes I made to the htmlhint executable:

[Arcanemagus]

Wow, that's quite a bug. Thanks for tracking this down @abraham and @admosity, I'm marking this as closed since it isn't a bug with linter-htmlhint.