Add Kinova JACO + MICO definitions to robot#32
Add Kinova JACO + MICO definitions to robot#32AndrejOrsula merged 6 commits intoAndrejOrsula:masterfrom
Conversation
Merge upstream into this repo
AndrejOrsula
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Looks good to me. I personally include such configs directly inside projects that require it, e.g. here for j2s7s300, but I have no problem with merging this. I have just one comment below.
|
Thank you so much for giving this a look, this was partially a simpler PR to ask for your preferred procedures before asking for reviews of beefier code changes. Please let me know if there is anything I can do in the PR (e.g. a template) to make things easier on your end. |
|
This is great. Thanks again! Just one more thing: Could you please run it through # Install via pip
pip install --user pre-commit
# Run pre-commit hooks (`--all` to consider all/unchanged files)
pre-commit run --all |
|
@AndrejOrsula done! |
|
Great. Thank you for your contribution! |
Matching the style of the
pandaarm and the MoveIt definitions from the kinova-ros repo.Please lmk if you have specific PR procedures to follow. We will have future PRs that address a few of the following issues: