Skip to content

Add Kinova JACO + MICO definitions to robot#32

Merged
AndrejOrsula merged 6 commits intoAndrejOrsula:masterfrom
personalrobotics:egordon/add_jaco
Aug 23, 2023
Merged

Add Kinova JACO + MICO definitions to robot#32
AndrejOrsula merged 6 commits intoAndrejOrsula:masterfrom
personalrobotics:egordon/add_jaco

Conversation

@egordon
Copy link
Contributor

@egordon egordon commented Aug 15, 2023

Matching the style of the panda arm and the MoveIt definitions from the kinova-ros repo.

Please lmk if you have specific PR procedures to follow. We will have future PRs that address a few of the following issues:

  • Adding collision primitives
  • Adding async planning + a way to cancel execution
  • Adding async FK/IK
  • Adding path constraints

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Looks good to me. I personally include such configs directly inside projects that require it, e.g. here for j2s7s300, but I have no problem with merging this. I have just one comment below.

@egordon
Copy link
Contributor Author

egordon commented Aug 17, 2023

Thank you so much for giving this a look, this was partially a simpler PR to ask for your preferred procedures before asking for reviews of beefier code changes. Please let me know if there is anything I can do in the PR (e.g. a template) to make things easier on your end.

@egordon egordon requested a review from AndrejOrsula August 17, 2023 01:57
@AndrejOrsula
Copy link
Owner

This is great. Thanks again!

Just one more thing: Could you please run it through pre-commit for consistent formatting? There is a helper script within the repository here, or using the commands below. Thank you.

# Install via pip
pip install --user pre-commit
# Run pre-commit hooks (`--all` to consider all/unchanged files)
pre-commit run --all

@egordon
Copy link
Contributor Author

egordon commented Aug 22, 2023

@AndrejOrsula done!

@AndrejOrsula
Copy link
Owner

Great. Thank you for your contribution!

@AndrejOrsula AndrejOrsula merged commit afb0dbd into AndrejOrsula:master Aug 23, 2023
@amalnanavati amalnanavati deleted the egordon/add_jaco branch November 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants