Automatically rollout the trino-coordinator on config change#382
Automatically rollout the trino-coordinator on config change#382accorvin wants to merge 1 commit intoAICoE:mainfrom
Conversation
This change implements use of the https://github.com/pcjun97/kustomize-hash-annotator kustomize plugins to automatically annotate the trino-coordinator deployment with the hash of the trino-config secret. This way, any time we change the trino-config, the coordinator will automatically perform a new rollout without manual intervention.
|
/hold |
|
This change cannot be merged until we've added the new kustomize plugin to the argocd server. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@accorvin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This change depends on operate-first/toolbox#80 |
|
This change also depends on operate-first/continuous-deployment#149 being rolled out to our ArgoCD deployment |
|
@HumairAK this may be interesting for you folks |
|
We discovered that the config option added in #384 is a thing, so we don't actually need this change. That said, I'm going to still work on getting the plugin added into our argocd and toolbox images since I think it's hella useful - particularly for Superset. |
This change implements use of the
https://github.com/pcjun97/kustomize-hash-annotator kustomize plugins to
automatically annotate the trino-coordinator deployment with the hash of
the trino-config secret. This way, any time we change the trino-config,
the coordinator will automatically perform a new rollout without manual
intervention.