Skip to content

Automatically rollout the trino-coordinator on config change#382

Closed
accorvin wants to merge 1 commit intoAICoE:mainfrom
accorvin:trino-hash
Closed

Automatically rollout the trino-coordinator on config change#382
accorvin wants to merge 1 commit intoAICoE:mainfrom
accorvin:trino-hash

Conversation

@accorvin
Copy link
Member

@accorvin accorvin commented Jul 8, 2022

This change implements use of the
https://github.com/pcjun97/kustomize-hash-annotator kustomize plugins to
automatically annotate the trino-coordinator deployment with the hash of
the trino-config secret. This way, any time we change the trino-config,
the coordinator will automatically perform a new rollout without manual
intervention.

This change implements use of the
https://github.com/pcjun97/kustomize-hash-annotator kustomize plugins to
automatically annotate the trino-coordinator deployment with the hash of
the trino-config secret. This way, any time we change the trino-config,
the coordinator will automatically perform a new rollout without manual
intervention.
@accorvin
Copy link
Member Author

accorvin commented Jul 8, 2022

/hold

@accorvin
Copy link
Member Author

accorvin commented Jul 8, 2022

This change cannot be merged until we've added the new kustomize plugin to the argocd server.

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@sesheta sesheta requested review from DharmitD and lucferbux July 8, 2022 17:45
@sesheta
Copy link

sesheta commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from accorvin after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2022
@sesheta
Copy link

sesheta commented Jul 8, 2022

@accorvin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/kustomize-build d22a3ae link true /test kustomize-build

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@accorvin
Copy link
Member Author

accorvin commented Jul 8, 2022

This change depends on operate-first/toolbox#80

@accorvin
Copy link
Member Author

accorvin commented Jul 8, 2022

This change also depends on operate-first/continuous-deployment#149 being rolled out to our ArgoCD deployment

@anishasthana
Copy link
Contributor

@HumairAK this may be interesting for you folks

@accorvin
Copy link
Member Author

accorvin commented Jul 8, 2022

We discovered that the config option added in #384 is a thing, so we don't actually need this change. That said, I'm going to still work on getting the plugin added into our argocd and toolbox images since I think it's hella useful - particularly for Superset.

@accorvin accorvin closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants