Skip to content

Add the kustomize-hash-annotator kustomize plugin#149

Merged
sesheta merged 2 commits intooperate-first:masterfrom
accorvin:add-hash-annotator
Jul 18, 2022
Merged

Add the kustomize-hash-annotator kustomize plugin#149
sesheta merged 2 commits intooperate-first:masterfrom
accorvin:add-hash-annotator

Conversation

@accorvin
Copy link
Copy Markdown
Member

@accorvin accorvin commented Jul 8, 2022

This adds the kustomize-hash-annotator 1 kustomize plugin to the
ArgoCD image. This plugin allows for dynamically annotating an object
with the hash of the contents of a configmap or secret, allowing for,
among other things, automatic rollouts of deployments based on updates
to configmaps and secrets.

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2022
@accorvin
Copy link
Copy Markdown
Member Author

accorvin commented Jul 8, 2022

@HumairAK I think maybe you're the maintainer of this. What do you think of this addition?

@accorvin
Copy link
Copy Markdown
Member Author

accorvin commented Jul 8, 2022

/retest

@Gregory-Pereira
Copy link
Copy Markdown
Member

It seems that the pre-commit pod cannot connect to GitHub (connection timeout) to clone down the pre-commit repo. I Will look into this.
/retest

@Gregory-Pereira
Copy link
Copy Markdown
Member

checking to see if the build-check also clones a git repo or uses networking in any way, to determine if this issue also affects other checks.
/retest

@HumairAK
Copy link
Copy Markdown
Member

I think this will result in the same issue as: operate-first/toolbox#80 (comment)

I.e. the entry for kind: field will be hashannotator and not HashAnnotator, the latter is what I think you are currently using in your manifests in idh.

@accorvin
Copy link
Copy Markdown
Member Author

@HumairAK do you have a take on which case is "correct"?

@HumairAK
Copy link
Copy Markdown
Member

HumairAK commented Jul 14, 2022

@accorvin I think the creator intended for HashAnnotator to be the correct one, since that's what their make file creates, and is shown in the examples.

This adds the kustomize-hash-annotator [1] kustomize plugin to the
ArgoCD image. This plugin allows for dynamically annotating an object
with the hash of the contents of a configmap or secret, allowing for,
among other things, automatic rollouts of deployments based on updates
to configmaps and secrets.

[1]: https://github.com/pcjun97/kustomize-hash-annotator
@accorvin accorvin force-pushed the add-hash-annotator branch from 78f6693 to 220b207 Compare July 18, 2022 13:15
@accorvin
Copy link
Copy Markdown
Member Author

@HumairAK as in the toolbox repo, this should be fixed now.

@HumairAK
Copy link
Copy Markdown
Member

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@sesheta
Copy link
Copy Markdown
Member

sesheta commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@sesheta sesheta merged commit 2c46a49 into operate-first:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants