Add the kustomize-hash-annotator kustomize plugin#149
Add the kustomize-hash-annotator kustomize plugin#149sesheta merged 2 commits intooperate-first:masterfrom
Conversation
|
@HumairAK I think maybe you're the maintainer of this. What do you think of this addition? |
|
/retest |
|
It seems that the pre-commit pod cannot connect to GitHub (connection timeout) to clone down the pre-commit repo. I Will look into this. |
|
checking to see if the build-check also clones a git repo or uses networking in any way, to determine if this issue also affects other checks. |
|
I think this will result in the same issue as: operate-first/toolbox#80 (comment) I.e. the entry for |
|
@HumairAK do you have a take on which case is "correct"? |
|
@accorvin I think the creator intended for |
This adds the kustomize-hash-annotator [1] kustomize plugin to the ArgoCD image. This plugin allows for dynamically annotating an object with the hash of the contents of a configmap or secret, allowing for, among other things, automatic rollouts of deployments based on updates to configmaps and secrets. [1]: https://github.com/pcjun97/kustomize-hash-annotator
78f6693 to
220b207
Compare
|
@HumairAK as in the toolbox repo, this should be fixed now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds the kustomize-hash-annotator 1 kustomize plugin to the
ArgoCD image. This plugin allows for dynamically annotating an object
with the hash of the contents of a configmap or secret, allowing for,
among other things, automatic rollouts of deployments based on updates
to configmaps and secrets.