Skip to content

Update the Trino ACLs every 30 seconds#384

Merged
accorvin merged 1 commit intoAICoE:mainfrom
accorvin:trino-refresh
Jul 8, 2022
Merged

Update the Trino ACLs every 30 seconds#384
accorvin merged 1 commit intoAICoE:mainfrom
accorvin:trino-refresh

Conversation

@accorvin
Copy link
Copy Markdown
Member

@accorvin accorvin commented Jul 8, 2022

With this we won't have to restart the trino coordinator anymore to
apply ACL changes.

With this we won't have to restart the trino coordinator anymore to
apply ACL changes.
@rimolive
Copy link
Copy Markdown
Member

rimolive commented Jul 8, 2022

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
Copy link
Copy Markdown
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the indentation off?

@sesheta sesheta requested review from anishasthana and lucferbux July 8, 2022 19:37
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2022
@accorvin
Copy link
Copy Markdown
Member Author

accorvin commented Jul 8, 2022

@anishasthana

Is the indentation off?

I don't think so. It's supposed to be a config setting in the access-control.properties file.

@sesheta
Copy link
Copy Markdown

sesheta commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@accorvin accorvin merged commit 55d47fc into AICoE:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants