xtools: get rid of warnings about wrong path by nashif · Pull Request #7 · zephyrproject-rtos/zephyr

nashif · 2017-04-28T12:47:55Z

Eliminate following errors:

make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command
not found
make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command
not found
make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command
not found

Also, usage of CROSS_COMPILE with a predefined toolchain is not required and
complicates things, just call CROSS_COMPILE with the full path if you
want to build with a toolchain not supported with Zephyr.

Signed-off-by: Anas Nashif anas.nashif@intel.com

This change is

Eliminate following errors: make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command not found make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command not found make[2]: /home/nashif/Work/sdk/xtools/outdir/x-tools//bin/-gcc: Command not found Also, usage of CROSS_COMPILE with a predefined toolchain is not required and complicates things, just call CROSS_COMPILE with the full path if you want to build with a toolchain not supported with Zephyr. Change-Id: I93ec4ff2e04d22cee82c8e4b74b652927572b30a Signed-off-by: Anas Nashif <anas.nashif@intel.com>

…td-17.06 Upstream merge 2 Jun 2017

[BLE] Ignore undefined callback functions if not set

IPC working stage

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

…ephyrproject-rtos#7)

Flush all messages and invoke `abort()` when a k_panic() or k_oops() is hit in native_posix mode. One of the main purposes of `native_posix` is to provide debug convenience. When running in a debugger, `abort()` stops execution which provides a backtrace and the ability to inspect all variables. A good, sample use case is fuzzing failures in SOF, see an example in: thesofproject/sof#8632 In such a case, this commit adds value even before using a debugger. Without this commit, confusingly meaningless stack trace: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb Exiting due to fatal error ==314134== ERROR: libFuzzer: fuzz target exited #0 0x81d9637 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9637) #1 0x80cc42b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc42b) zephyrproject-rtos#2 0x80ab79e in fuzzer::Fuzzer::ExitCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab864 in fuzzer::Fuzzer::StaticExitCallback() (zephyr.exe+ zephyrproject-rtos#4 0xf783dfe8 (/usr/lib32/libc.so.6+0x3dfe8) zephyrproject-rtos#5 0xf783e1e6 in exit (/usr/lib32/libc.so.6+0x3e1e6) zephyrproject-rtos#6 0x82a5488 in posix_exit boards/posix/native_posix/main.c:51:2 SUMMARY: libFuzzer: fuzz target exited ``` Thanks to this commit the `k_panic()` location is now immediately available in test logs without even running anything locally: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb @ WEST_TOPDIR/sof/src/ipc/ipc3/handler.c:1623 ZEPHYR FATAL ERROR: 3 ==315176== ERROR: libFuzzer: deadly signal LLVMSymbolizer: error reading file: No such file or directory #0 0x81d9647 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9647) #1 0x80cc43b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc43b) zephyrproject-rtos#2 0x80ab6be in fuzzer::Fuzzer::CrashCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab77b in fuzzer::Fuzzer::StaticCrashSignalCallback() zephyrproject-rtos#4 0xf7f3159f (linux-gate.so.1+0x59f) zephyrproject-rtos#5 0xf7f31578 (linux-gate.so.1+0x578) zephyrproject-rtos#6 0xf788ea16 (/usr/lib32/libc.so.6+0x8ea16) zephyrproject-rtos#7 0xf783b316 in raise (/usr/lib32/libc.so.6+0x3b316) zephyrproject-rtos#8 0xf7822120 in abort (/usr/lib32/libc.so.6+0x22120) zephyrproject-rtos#9 0x82afbde in ipc_cmd src/ipc/ipc3/handler.c:1623:2 NOTE: libFuzzer has rudimentary signal handlers. Combine libFuzzer with AddressSanitizer or similar for better crash reports. SUMMARY: libFuzzer: deadly signal ``` The full stack trace is now immediately available when running zephyr.exe in gdb: ``` ./scripts/fuzz.sh -- -DEXTRA_CFLAGS="-O0 -g3" gdb build-fuzz/zephyr/zephyr.exe run backtrace zephyrproject-rtos#2 0xf783b317 in raise () from /usr/lib32/libc.so.6 zephyrproject-rtos#3 0xf7822121 in abort () from /usr/lib32/libc.so.6 zephyrproject-rtos#4 0x082afbdf in ipc_cmd (_hdr=0x8b...) at src/ipc/ipc3/handler.c:1623 zephyrproject-rtos#5 0x082fbf4b in ipc_platform_do_cmd (ipc=0x8b161c0) at src/platform/posix/ipc.c:162 zephyrproject-rtos#6 0x082e1e07 in ipc_do_cmd (data=0x8b161c0 <heapmem+1472>) at src/ipc/ipc-common.c:328 zephyrproject-rtos#7 0x083696aa in task_run (task=0x8b161e8 <heapmem+1512>) at zephyr/include/rtos/task.h:94 zephyrproject-rtos#8 0x083682dc in edf_work_handler (work=0x8b1621c <heapmem+1564>) at zephyr/edf_schedule.c:32 zephyrproject-rtos#9 0x085245af in work_queue_main (workq_ptr=0x8b15b00 <edf_workq>,...) at zephyr/kernel/work.c:688 zephyrproject-rtos#10 0x0823a6bc in z_thread_entry (entry=0x8523be0 <work_queue_main>,.. at zephyr/lib/os/thread_entry.c:48 zephyrproject-rtos#11 0x0829a6a1 in posix_arch_thread_entry (pa_thread_status=0x8630648 .. at zephyr/arch/posix/core/thread.c:56 zephyrproject-rtos#12 0x0829c043 in posix_thread_starter (arg=0x4) at zephyr/arch/posix/core/posix_core.c:293 zephyrproject-rtos#13 0x080f6041 in asan_thread_start(void*) () zephyrproject-rtos#14 0xf788c73c in ?? () from /usr/lib32/libc.so.6 ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>

Disabling to prevent USB TTA from introducting extra EFI boot-target.

# Conflicts: # drivers/gpio/gpio_stm32.c

Ambiq zephyr currently provides LVGL support only for Apollo 510. This commit ports this support to Apollo 510B too. Signed-off-by: Ladislav Podivin <EXTLAPO@bang-olufsen.dk> (cherry picked from commit 1c49a23e4548c9afa990a6ca99e39071d9776e58)

This reverts commit d3773a1. Signed-off-by: Ladislav Podivin <EXTLAPO@bang-olufsen.dk>

ASM is notoriously harder to maintain than C and requires core specific adaptation which impairs even more the readability of the code. There's a bug in current arch_cpu_atomic_idle asm version: tst x0, #(DAIF_IRQ_BIT) //here Z := (DAIF_IRQ_BIT == 0) beq _irq_disabled //jump to _irq_disabled when Z is set msr daifclr, #(DAIFCLR_IRQ_BIT) _irq_disabled: ret As can be seen, the asm code jumps to _irq_disabled when Z is set, but per aarch64 architecture reference, DAIF_IRQ == 0 means the IRQ is unmasked, I.E enabled. So the asm logic here is wrong. I fixed this bug in C version. This shows the benefit of ASM -> C As for performance concern, except the bug fix above, there's no difference of generated code between ASM and C version. ASM version: <arch_cpu_idle>: d5033f9f dsb sy d503207f wfi d50342ff msr daifclr, #0x2 d65f03c0 ret arch_cpu_atomic_idle>: d50342df msr daifset, #0x2 d5033fdf isb d503205f wfe f279001f tst x0, #0x80 54000040 b.eq 1001d10 <_irq_disabled> // b.none d50342ff msr daifclr, #0x2 _irq_disabled>: d65f03c0 ret C version: <arch_cpu_idle>: d5033f9f dsb sy d503207f wfi d50342ff msr daifclr, #0x2 d65f03c0 ret <arch_cpu_atomic_idle>: d50342df msr daifset, #0x2 d5033fdf isb d503205f wfe 37380040 tbnz w0, zephyrproject-rtos#7, 1001d0c <arch_cpu_atomic_idle+0x14> d50342ff msr daifclr, #0x2 d65f03c0 ret And as can be seen, C version use the tbnz instruction to test bit and branch. Unlike TST, TBNZ does not affect the Z, N, C, or V flags in the processor state. So except the bug fix, C version looks a bit better than asm version. Other architectures such as x86, riscv, rx, xtensa, mips and even arm cortex_m also use c version for cpu_idle, it's safe for ASM -> C. Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

ASM is notoriously harder to maintain than C and requires core specific adaptation which impairs even more the readability of the code. There's a bug in current arch_cpu_atomic_idle asm version: tst x0, #(DAIF_IRQ_BIT) //here Z := (DAIF_IRQ_BIT == 0) beq _irq_disabled //jump to _irq_disabled when Z is set msr daifclr, #(DAIFCLR_IRQ_BIT) _irq_disabled: ret As can be seen, the asm code jumps to _irq_disabled when Z is set, but per aarch64 architecture reference, DAIF_IRQ == 0 means the IRQ is unmasked, I.E enabled. So the asm logic here is wrong. I fixed this bug in C version. This shows the benefit of ASM -> C As for performance concern, except the bug fix above, there's no difference of generated code between ASM and C version. ASM version: <arch_cpu_idle>: d5033f9f dsb sy d503207f wfi d50342ff msr daifclr, #0x2 d65f03c0 ret arch_cpu_atomic_idle>: d50342df msr daifset, #0x2 d5033fdf isb d503205f wfe f279001f tst x0, #0x80 54000040 b.eq 1001d10 <_irq_disabled> // b.none d50342ff msr daifclr, #0x2 _irq_disabled>: d65f03c0 ret C version: <arch_cpu_idle>: d5033f9f dsb sy d503207f wfi d50342ff msr daifclr, #0x2 d65f03c0 ret <arch_cpu_atomic_idle>: d50342df msr daifset, #0x2 d5033fdf isb d503205f wfe 37380040 tbnz w0, #7, 1001d0c <arch_cpu_atomic_idle+0x14> d50342ff msr daifclr, #0x2 d65f03c0 ret And as can be seen, C version use the tbnz instruction to test bit and branch. Unlike TST, TBNZ does not affect the Z, N, C, or V flags in the processor state. So except the bug fix, C version looks a bit better than asm version. Other architectures such as x86, riscv, rx, xtensa, mips and even arm cortex_m also use c version for cpu_idle, it's safe for ASM -> C. Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

nashif added the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Apr 28, 2017

nashif requested a review from galak May 4, 2017 15:23

nashif merged commit 96def63 into zephyrproject-rtos:master May 19, 2017

nashif deleted the xtools_Fix branch May 19, 2017 22:38

rsalveti added a commit to rsalveti/zephyr that referenced this pull request Jun 29, 2017

[LTD mergeup] Merge pull request zephyrproject-rtos#7 from rsalveti/l…

f61d186

…td-17.06 Upstream merge 2 Jun 2017

dhavalpanchalispl mentioned this pull request Oct 16, 2017

arduino_101: USB device is not listed after flashing with a Zephyr sample #4351

Closed

nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017

Merge pull request zephyrproject-rtos#7 from jimmy-huang/master

e061a69

[BLE] Ignore undefined callback functions if not set

rmstoi mentioned this pull request Feb 9, 2018

echo server crash from corrupt ICMPv4 packet #6081

Closed

magilus mentioned this pull request Feb 3, 2019

Dead loop of the kernel during Bluetooth Mesh pressure communication #12726

Closed

This was referenced Jun 13, 2019

kernel timeout_list repeatedly add a thread #16793

Closed

Bluetooth: Mesh: Rx buffer exhaustion causes deadlock #16864

Closed

avisconti mentioned this pull request Jun 20, 2019

west: Update hal_stm32 module for stm32f4 series cube update #16959

Closed

xiaoliang314 mentioned this pull request Jun 26, 2019

Bluetooth: Fix various deadlock issues when running low on buffers #16870

Closed

dcpleung pushed a commit to dcpleung/zephyr that referenced this pull request Aug 21, 2019

Merge pull request zephyrproject-rtos#7 from finikorg/up_squared_adsp

f8f3db8

IPC working stage

ghost mentioned this pull request Jan 30, 2020

LIS2DH SPI Support #22348

Closed

zephyrbot mentioned this pull request Apr 22, 2020

net: socket: syscall for socketpair(2) #24367

Closed

sjanc mentioned this pull request May 16, 2023

Assert when executing GATT/SR/GAW/BV-14-C test #57930

Closed

gromero mentioned this pull request Jul 6, 2023

retained_mem/retention: Allow disabling mutex support #59264

Merged

pkunieck pushed a commit to pkunieck/zephyr that referenced this pull request Jul 18, 2023

Fix container-api twister param bug + compress workflows with matrix (z…

84cc496

…ephyrproject-rtos#7)

talih0 mentioned this pull request Dec 13, 2023

subsys: shell_telent: don't close connection on EAGAIN #66287

Merged

lgl88911 mentioned this pull request May 18, 2024

Linking picolibc's srand to esp32c3 causes startup fault #69708

Closed

LukaszMrugala pushed a commit to LukaszMrugala/zephyr that referenced this pull request Jul 3, 2024

remotehw: upx-whl: disable virtual USB functions (zephyrproject-rtos#7)

296c52b

Disabling to prevent USB TTA from introducting extra EFI boot-target.

kartben mentioned this pull request Jul 31, 2024

boards: shield: Support touch for the NXP LCD-PAR-S035 LCD on MCXN947 #75353

Closed

bayannagetteboina-eaton mentioned this pull request Nov 12, 2024

Issue through RAM / ROM summary #81261

Closed

RadekPolyend mentioned this pull request Feb 3, 2025

drivers: usb: udc: udc_mcux_ehci: UDC_MCUX_EHCI tries to acquire mutex within the ISR #85070

Closed

FlorianWeber1018 mentioned this pull request Feb 21, 2025

drivers: usb: device: raspberrypi_pico_usbd - use of uninitialized semaphore #83806

Closed

wentywenty mentioned this pull request Jun 8, 2025

[BUG] STM32F411CE: BSS segment memory corruption during z_bss_zero() causes infinite loop in memset #91267

Closed

1 task

hakehuang mentioned this pull request Jun 30, 2025

drivers: video: smartdma: crash in some cases #92299

Closed

1 task

sjanc mentioned this pull request Sep 17, 2025

Bluetooth: ISO: Null pointer deference in iso.c on link disconnect #96155

Closed

1 task

fei315412-cmyk mentioned this pull request Oct 29, 2025

lib: os: mpsc_pbuf: fix potential semaphore wait forever #97931

Closed

sjanc mentioned this pull request Nov 7, 2025

Crash in bluetooth tester when executing BAP/BSRC/SCC/BV-21-C qualification test #99045

Closed

1 task

ndrs-pst added a commit to DDC-NDRS/zephyr_rtos that referenced this pull request Nov 19, 2025

merge: 'upstream' into pst-v4.3.99 zephyrproject-rtos#7

2808adb

# Conflicts: # drivers/gpio/gpio_stm32.c

ndrs-pst added a commit to DDC-NDRS/zephyr_rtos that referenced this pull request Nov 29, 2025

merge: 'upstream' into pst-v4.3.99 zephyrproject-rtos#7

ee29b61

ladivin added a commit to bang-olufsen/zephyr that referenced this pull request Feb 16, 2026

Revert "Add LVGL support for 510B (zephyrproject-rtos#7)"

169d904

This reverts commit d3773a1. Signed-off-by: Ladislav Podivin <EXTLAPO@bang-olufsen.dk>

ladivin added a commit to bang-olufsen/zephyr that referenced this pull request Feb 16, 2026

Revert "Add LVGL support for 510B (zephyrproject-rtos#7)"

7fefecc

This reverts commit d3773a1. Signed-off-by: Ladislav Podivin <EXTLAPO@bang-olufsen.dk>

jfischer-no mentioned this pull request Feb 19, 2026

usb: prevent yielding from usb_write when in isr #104270

Closed

surfskidude mentioned this pull request Mar 19, 2026

getaddrinfo fails with -EAI_MEMORY in Zephyr 4.3.99 #105771

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xtools: get rid of warnings about wrong path#7

xtools: get rid of warnings about wrong path#7
nashif merged 1 commit intozephyrproject-rtos:masterfrom
nashif:xtools_Fix

nashif commented Apr 28, 2017 •

edited by galak

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nashif commented Apr 28, 2017 • edited by galak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nashif commented Apr 28, 2017 •

edited by galak

Loading