Bluetooth: controller: Refactor ll c into states/roles files by cvinayak · Pull Request #15 · zephyrproject-rtos/zephyr

cvinayak · 2017-04-29T13:49:55Z

Collection of commit to refactor ll.c file.

This change is

cvinayak · 2017-05-02T11:41:04Z

@jhedberg @carlescufi @Vudentz Please do the needful!

The current implementation of stm32_gpio_set() uses the GPIO output data register to change the state of individual GPIOs. The generated assembler needs at least 3 instructions: load / modify / store. This opens a small race window, for example if a thread and an interrupt both try to change the state of the same GPIO bank. Use the GPIO bit set/reset register to perform the atomic change without locking. This also has the benefit of a more optimised implementation, which can be useful for GPIO-intensive work. Compare the new version: 08000c98 <stm32_gpio_set>: 8000c98: f001 010f and.w r1, r1, zephyrproject-rtos#15 8000c9c: 2301 movs r3, zephyrproject-rtos#1 8000c9e: b902 cbnz r2, 8000ca2 <stm32_gpio_set+0xa> 8000ca0: 3110 adds r1, zephyrproject-rtos#16 8000ca2: 408b lsls r3, r1 8000ca4: 6183 str r3, [r0, zephyrproject-rtos#24] 8000ca6: 2000 movs r0, #0 8000ca8: 4770 bx lr and the old one: 08000c98 <stm32_gpio_set>: 8000c98: 2301 movs r3, zephyrproject-rtos#1 8000c9a: f001 010f and.w r1, r1, zephyrproject-rtos#15 8000c9e: fa03 f101 lsl.w r1, r3, r1 8000ca2: 6943 ldr r3, [r0, zephyrproject-rtos#20] 8000ca4: b10a cbz r2, 8000caa <stm32_gpio_set+0x12> 8000ca6: 4319 orrs r1, r3 8000ca8: e001 b.n 8000cae <stm32_gpio_set+0x16> 8000caa: ea23 0101 bic.w r1, r3, r1 8000cae: 6141 str r1, [r0, zephyrproject-rtos#20] 8000cb0: 2000 movs r0, #0 8000cb2: 4770 bx lr Change-Id: Ie5800d1c345016028d1b9a099f5d74cac35f592a Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>

jhedberg · 2017-05-04T07:10:49Z

subsys/bluetooth/controller/hci/hci.c

Could you try to reorder the case statments so that each #if-#endif pair only appears once?

Sure.

Lets see if this comment is lost!

No this review/comment is not lost when doing git push -f.

In preparation for refactoring the Controller implementation into seperate state and role based source files, add Kconfig options for states and roles in the Controller. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Move advertising state related implementation out into a separate ll_adv.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Move scanning state related implementation out into a separate ll_scan.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Move master role related implementation out into a separate ll_master.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Conditionally compile slave role related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Conditionally compile connection state related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

feat: WDT: added WDT demo application Closes zephyrproject-rtos#15 See merge request blik/embedded/zephyr!25

Set of latest patches

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt

…r zephyrproject-rtos/lvgl

- Minor cleanup, tweaks to tag_main.sh. - Added the pr_comment.sh script * writes a comment to a PR with the rebase tag info * Works for both zephyr and zephyr-intel manifest update PRs Signed-off-by: Connor Graydon <connor.graydon@intel.com>

Merge dev_mspm33 to main_mspm33

# Conflicts: # drivers/i2c/i2c_shell.c # drivers/modem/modem_cellular.c # drivers/spi/spi_stm32.c # drivers/timer/cortex_m_systick.c # include/zephyr/toolchain/gcc.h

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from fd12640 to 8c78e32 Compare April 29, 2017 14:21

jhedberg force-pushed the bluetooth branch from 1914fc3 to e588ca0 Compare May 1, 2017 12:55

jhedberg requested a review from Vudentz May 1, 2017 14:08

Vudentz previously approved these changes May 1, 2017

View reviewed changes

cvinayak changed the base branch from bluetooth to master May 1, 2017 18:37

jhedberg assigned carlescufi May 2, 2017

jhedberg requested a review from carlescufi May 2, 2017 05:31

carlescufi previously approved these changes May 2, 2017

View reviewed changes

jhedberg self-requested a review May 2, 2017 10:05

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 8c78e32 to caad338 Compare May 2, 2017 11:38

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from caad338 to 19c80cb Compare May 3, 2017 13:50

cvinayak dismissed carlescufi’s stale review via 8ff2b85 May 4, 2017 06:30

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 19c80cb to 8ff2b85 Compare May 4, 2017 06:30

jhedberg reviewed May 4, 2017

View reviewed changes

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch 2 times, most recently from aac5133 to 776a426 Compare May 4, 2017 10:06

cvinayak added 6 commits May 4, 2017 19:43

Bluetooth: controller: Refactor LL Adv state to ll_adv.c file

afbcfad

Move advertising state related implementation out into a separate ll_adv.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Bluetooth: controller: Refactor LL Scan state to ll_scan.c file

1e697af

Move scanning state related implementation out into a separate ll_scan.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Bluetooth: controller: Refactor LL Master role to ll_master.c

1f0df0d

Move master role related implementation out into a separate ll_master.c file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Bluetooth: controller: Conditionally compile slave role HCI cmds

5ee00fd

Conditionally compile slave role related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Bluetooth: controller: Cond. compile connection state HCI cmds

1433b32

Conditionally compile connection state related HCI commands. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

cvinayak dismissed Vudentz’s stale review via 1433b32 May 4, 2017 18:34

cvinayak force-pushed the github_bluetooth_refactor_ll_c branch from 776a426 to 1433b32 Compare May 4, 2017 18:34

jhedberg approved these changes May 5, 2017

View reviewed changes

Merge branch 'master' into github_bluetooth_refactor_ll_c

e34363e

carlescufi approved these changes May 5, 2017

View reviewed changes

Merge branch 'master' into github_bluetooth_refactor_ll_c

6e778d0

frasa added a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019

Merge branch 'feat-watchdog' into 'dev'

83987a0

feat: WDT: added WDT demo application Closes zephyrproject-rtos#15 See merge request blik/embedded/zephyr!25

xiaoliang314 mentioned this pull request Jun 17, 2019

Bluetooth: Mesh: Rx buffer exhaustion causes deadlock #16864

Closed

xiaoliang314 mentioned this pull request Jun 26, 2019

Bluetooth: Fix various deadlock issues when running low on buffers #16870

Closed

finikorg pushed a commit to finikorg/zephyr that referenced this pull request Oct 25, 2019

Merge pull request zephyrproject-rtos#15 from finikorg/for-upstream2

92a128c

Set of latest patches

anchao mentioned this pull request Jul 30, 2020

Bluetooth: Mesh: Fix tx seg buffer with NULL pointer reference #27251

Merged

stephanosio mentioned this pull request Jun 24, 2021

lib/gui/lvgl: Add user config file #36479

Closed

fkan-ec pushed a commit to fkan-ec/zephyr that referenced this pull request Jan 17, 2022

Merge pull request zephyrproject-rtos#15 from ec-platform-sw/BUG_2882

21ca5e6

[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt

RafaelLeeImg mentioned this pull request Jan 19, 2022

Kernel usage fault when using semaphore with multi-threading #41963

Closed

gigiduck pushed a commit to gigiduck/zephyr that referenced this pull request Feb 7, 2022

Sideloaded lvgl v8 from repo in pull request zephyrproject-rtos#15 fo…

17a4ad7

…r zephyrproject-rtos/lvgl

piotrParf mentioned this pull request Feb 9, 2022

BLE Testing functions do not work properly #42534

Closed

dleach02 mentioned this pull request Oct 19, 2022

hal: nxp: ARRAY_SIZE collision #51371

Closed

NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022

[LFS] Fixing mount error reporting (zephyrproject-rtos#15)

5ca7e7f

dleach02 mentioned this pull request Oct 19, 2022

sys: util: Prevent multiple definitions of ARRAY_SIZE #50239

Closed

sjanc mentioned this pull request May 16, 2023

Assert when executing GATT/SR/GAW/BV-14-C test #57930

Closed

DavidCPlatt mentioned this pull request Dec 7, 2024

RP2040 (Raspberry Pi Pico) fails to start up - code clobbered or XIP-flash inaccessible? #82632

Closed

RadekPolyend mentioned this pull request Feb 3, 2025

drivers: usb: udc: udc_mcux_ehci: UDC_MCUX_EHCI tries to acquire mutex within the ISR #85070

Closed

FlorianWeber1018 mentioned this pull request Feb 21, 2025

drivers: usb: device: raspberrypi_pico_usbd - use of uninitialized semaphore #83806

Closed

fei315412-cmyk mentioned this pull request Oct 29, 2025

lib: os: mpsc_pbuf: fix potential semaphore wait forever #97931

Closed

Grippy98 referenced this pull request in TexasInstruments/msp-zephyr Nov 12, 2025

Merge pull request #15 from TexasInstruments/dev_mspm33

b33065d

Merge dev_mspm33 to main_mspm33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bluetooth: controller: Refactor ll c into states/roles files#15

Bluetooth: controller: Refactor ll c into states/roles files#15
jhedberg merged 9 commits intozephyrproject-rtos:masterfrom
cvinayak:github_bluetooth_refactor_ll_c

cvinayak commented Apr 29, 2017 •

edited by galak

Loading

Uh oh!

cvinayak commented May 2, 2017

Uh oh!

jhedberg May 4, 2017

Uh oh!

cvinayak May 4, 2017

Uh oh!

cvinayak May 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cvinayak commented Apr 29, 2017 • edited by galak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvinayak commented May 2, 2017

Uh oh!

jhedberg May 4, 2017

Choose a reason for hiding this comment

Uh oh!

cvinayak May 4, 2017

Choose a reason for hiding this comment

Uh oh!

cvinayak May 4, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cvinayak commented Apr 29, 2017 •

edited by galak

Loading