Add test coverage for special characters in manifest and west commands#928
Open
marc-hb wants to merge 4 commits intozephyrproject-rtos:mainfrom
Open
Add test coverage for special characters in manifest and west commands#928marc-hb wants to merge 4 commits intozephyrproject-rtos:mainfrom
marc-hb wants to merge 4 commits intozephyrproject-rtos:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
marc-hb
force-pushed
the
backslash-tests
branch
2 times, most recently
from
7b254a9 to
b30eff3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 85.95% 86.06% +0.11%
==========================================
Files 11 11
Lines 3454 3460 +6
==========================================
+ Hits 2969 2978 +9
+ Misses 485 482 -3 |
This comment was marked as resolved.
This comment was marked as resolved.
Minor whitespace changes to get closer with the default yaml.dump() and west manifest --resolve output formats. This does not reduce diffs entirely to zero but it does considerably and makes them readable. Zero functional change. Signed-off-by: Marc Herbert <[email protected]>
This makes on-the-fly changes to test configurations more convenient. Signed-off-by: Marc Herbert <[email protected]>
Detect any unexpected changes in the way we've been handling backslashes and multiple slashes in paths. Changes in how we handle such edge cases may or may not be desired (and this test may be updated accordingly), but we never want these changes to come as a surprise and we want to keep control over them. This came up as part of the review for zephyrproject-rtos#920 which fixes zephyrproject-rtos#725 Signed-off-by: Marc Herbert <[email protected]>
Add some test coverage for forward and backslashes + whitespace in filenames for west extensions Spurred by a discussion in the review of zephyrproject-rtos#920 which fixes zephyrproject-rtos#725 Signed-off-by: Marc Herbert <[email protected]>
This was referenced Mar 6, 2026
pdgendt
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure tests changes.
Prompted by the #920 fix.
cc: @nmunnich