tests: stop hardcoding a forward slash in 'scripts/west-commands.yml'#921
Closed
marc-hb wants to merge 1 commit intozephyrproject-rtos:mainfrom
Closed
tests: stop hardcoding a forward slash in 'scripts/west-commands.yml'#921marc-hb wants to merge 1 commit intozephyrproject-rtos:mainfrom
marc-hb wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
marc-hb
force-pushed
the
commands-backslash
branch
from
f7a15de to
603e534
Compare
marc-hb
force-pushed
the
commands-backslash
branch
from
603e534 to
d6046cb
Compare
Use backwards slashes on Windows to catch any future hardcoding mistake. Minor oversight found while discussing zephyrproject-rtos#920
marc-hb
force-pushed
the
commands-backslash
branch
from
d6046cb to
8fe0d30
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 11 11
Lines 3453 3453
=======================================
Hits 2968 2968
Misses 485 485 |
Collaborator
Author
|
Following some feedback from @pdgendt , to be replaced by more specific tests like this: |
Collaborator
Author
Submitted #928 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use backwards slashes on Windows to catch any future hardcoding mistake.
Minor oversight found while discussing #920