-
Notifications
You must be signed in to change notification settings - Fork 153
De-tox and uv-ify #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-tox and uv-ify #845
Changes from all commits
ec8ee90
e5716fd
42ea165
a1d8bb3
902db66
45fe43a
b303470
bf24aaa
df16a85
222861d
e1f4f7f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,19 +27,21 @@ jobs: | |
| path: "./check out" | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@b75a909f75acd358c2196fb9a5f1299a9a8868a4 # v6.7.0 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| working-directory: './check out/' | ||
| enable-cache: true | ||
|
|
||
| - name: Display Python version | ||
| run: python -c "import sys; print(sys.version); print(sys.platform)" | ||
|
|
||
| - name: Install tox | ||
| run: pip3 install tox | ||
| - name: Setup project | ||
| run: uv sync --frozen --directory "./check out/" | ||
|
|
||
| - name: Run tox | ||
| run: tox -c 'check out' -- -W error | ||
| - name: Run tasks | ||
| run: uv run --frozen --directory "./check out/" poe all | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you not run "all" here to provide finer-grained results? And durations.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is close to what
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Submitted in: |
||
|
|
||
| - name: Upload coverage reports | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This new version of the README.rst seems to hesitate between embracing the new
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to keep options open for developers. BTW, I intend to re-vamp the readme together with moving the docs from Zephyr to a West site, and create a dedicated page for testing west itself.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Big doc move WIP in: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,12 @@ | ||
| # Copyright (c) 2024, Basalte bv | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import os | ||
| import subprocess | ||
|
|
||
| import pytest | ||
| from conftest import cmd | ||
|
|
||
| assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ha, I'm finally understanding the "detox" pun :-) This would be great: because of too many layers, so far my only solution to run a test in a debugger was Don't forget to update b7e091d
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unless... the Sorry for thinking out loud. Hey it's just a draft PR ;-)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I want to reduce the layering too, it should be possible to run |
||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def autouse_tmpdir(config_tmpdir, west_init_tmpdir): | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH runners are ephemeral so it does really matter but... just for better "role-modelling" maybe?
Only if pipx is available by default, otherwise forget it.