Skip to content

ci: Split 'all' into smaller tasks#858

Merged
pdgendt merged 2 commits intozephyrproject-rtos:mainfrom
pdgendt:ci-tasks
Oct 7, 2025
Merged

ci: Split 'all' into smaller tasks#858
pdgendt merged 2 commits intozephyrproject-rtos:mainfrom
pdgendt:ci-tasks

Conversation

@pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Oct 7, 2025

Run testing on the different supported versions while running the linter and type checks only on 1 combination.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.52%. Comparing base (ba70229) to head (48c4435).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files          11       11           
  Lines        3366     3366           
=======================================
  Hits         2845     2845           
  Misses        521      521           

@pdgendt pdgendt requested a review from marc-hb October 7, 2025 15:13
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['3.10', '3.11', '3.12', '3.13']
task: [test]
include:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the ways to extend GH matrices super obtuse; I have to go back to the docs every time. Can you please use comment(s) to warn the reader about that? I mean this is one of those rare cases where readers are deceived into thinking "How hard to understand could this simple syntax be? I really don't need to spend time finding the documentation".

But yes they do. Otherwise they waste a lot more time.

  • It's really not intuitive that include extends!
  • It's not intuitive either that test does not get overwritten and still runs for 3.13.

So please mention these, and also strongly recommend to open the documentation. It's currently at
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-adding-configurations but maybe just the section name in the doc is more "permanent" and enough.

Otherwise everything looks good.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment with a link to the docs

Run testing on the different supported versions while running the linter
and type checks only on 1 combination.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Using uv we need to wrap the Python commands, otherwise the environment
isn't taken into account.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@marc-hb

This comment was marked as off-topic.

@pdgendt pdgendt merged commit bfaf5fa into zephyrproject-rtos:main Oct 7, 2025
22 checks passed
@pdgendt pdgendt deleted the ci-tasks branch October 7, 2025 19:24
@marc-hb marc-hb mentioned this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants