Remove async backing

[Chralt98]

What does it do?

Related to this issue.

What important points should reviewers know?

This PR results in an error in the block production process (set_validation_data) on the client side similar to this:

2025-06-04 15:54:18.009 DEBUG tokio-runtime-worker parachain::collation-generation: [Relaychain] Occupied core(s) assumption relay_parent=0x2de14a301b645093adf5acaa21751533ef16b1a083d1b93471b6ce164b0378d5 our_para=2101 para_assumption=OccupiedCoreAssumption::Included
2025-06-04 15:54:18.009  INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: [🔮 Zeitgeist Parachain] 🙌 Starting consensus session on top of parent 0xbb1b8d6ae594fb09432d5c95073efa4a13b7f1494d73cd65167a879e15c7fb6c (#1)    
2025-06-04 15:54:18.010 ERROR tokio-runtime-worker runtime: [🔮 Zeitgeist Parachain] panicked at /home/chralt/.cargo/git/checkouts/polkadot-sdk-dee0edd6eefa0594/87971b3/cumulus/pallets/parachain-system/src/lib.rs:1212:5:
assertion `left == right` failed: expected parent to be included
  left: 0x510b52596fcbbc383e6cdf12b4cf36c9bb0edbf67325fda103e3dfb618ebdc6e
 right: 0xbb1b8d6ae594fb09432d5c95073efa4a13b7f1494d73cd65167a879e15c7fb6c    
2025-06-04 15:54:18.010  WARN tokio-runtime-worker sp_state_machine::overlayed_changes::changeset: [🔮 Zeitgeist Parachain] 1 storage transactions are left open by the runtime. Those will be rolled back.    
2025-06-04 15:54:18.010  WARN tokio-runtime-worker sp_state_machine::overlayed_changes::changeset: [🔮 Zeitgeist Parachain] 1 storage transactions are left open by the runtime. Those will be rolled back.    
2025-06-04 15:54:18.010  WARN tokio-runtime-worker basic-authorship: [🔮 Zeitgeist Parachain] ❗️ Inherent extrinsic returned unexpected error: Error at calling runtime api: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x6502d4 - battery_station_runtime.wasm!rust_begin_unwind
    1: 0x5e6eb5 - battery_station_runtime.wasm!core::panicking::panic_fmt::he905bcb57f481db7
    2: 0x5e710a - battery_station_runtime.wasm!core::panicking::assert_failed_inner::h010277ed1405cdbe
    3: 0x5f88b2 - battery_station_runtime.wasm!core::panicking::assert_failed::h98a0f295e947ea2a
    4: 0x2c5623 - battery_station_runtime.wasm!cumulus_pallet_parachain_system::<impl cumulus_pallet_parachain_system::pallet::Pallet<T>>::maybe_drop_included_ancestors::h62ad389e4546cd03
    5: 0x24edcc - battery_station_runtime.wasm!frame_support::storage::transactional::with_transaction::hed1a2476adc33393
    6: 0x2a3177 - battery_station_runtime.wasm!environmental::local_key::LocalKey<T>::with::h943a4fee04530efd
    7: 0x154e5 - battery_station_runtime.wasm!<battery_station_runtime::RuntimeCall as frame_support::traits::dispatch::UnfilteredDispatchable>::dispatch_bypass_filter::hb69f7ea180b8257a
    8: 0x1370e - battery_station_runtime.wasm!<battery_station_runtime::RuntimeCall as sp_runtime::traits::Dispatchable>::dispatch::h415ff27f611b4dc1
    9: 0xcb2cd - battery_station_runtime.wasm!<sp_runtime::generic::checked_extrinsic::CheckedExtrinsic<AccountId,Call,Extra> as sp_runtime::traits::Applyable>::apply::h93cd2872d03bef44
   10: 0x3b77f6 - battery_station_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::apply_extrinsic::h27e6b8dddefbe840
   11: 0x4bcbc9 - battery_station_runtime.wasm!BlockBuilder_apply_extrinsic. Dropping.    
2025-06-04 15:54:18.034 ERROR tokio-runtime-worker runtime: [🔮 Zeitgeist Parachain] panicked at /home/chralt/.cargo/git/checkouts/polkadot-sdk-dee0edd6eefa0594/87971b3/cumulus/pallets/parachain-system/src/lib.rs:263:6:
set_validation_data inherent needs to be present in every block!    
2025-06-04 15:54:18.034 ERROR tokio-runtime-worker filtering-consensus: [🔮 Zeitgeist Parachain] err=Error { inner: Proposing

Caused by:
    0: Error at calling runtime api: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
       WASM backtrace:
       error while executing at wasm backtrace:
           0: 0x6502d4 - battery_station_runtime.wasm!rust_begin_unwind
           1: 0x5e6eb5 - battery_station_runtime.wasm!core::panicking::panic_fmt::he905bcb57f481db7
           2: 0x5e6aa5 - battery_station_runtime.wasm!core::option::expect_failed::hec30617e7e3a43fd
           3: 0x2d4cf7 - battery_station_runtime.wasm!<(TupleElement0,TupleElement1,TupleElement2,TupleElement3,TupleElement4,TupleElement5,TupleElement6,TupleElement7,TupleElement8,TupleElement9,TupleElement10,TupleElement11,TupleElement12,TupleElement13,TupleElement14,TupleElement15,TupleElement16,TupleElement17,TupleElement18,TupleElement19,TupleElement20,TupleElement21,TupleElement22,TupleElement23,TupleElement24,TupleElement25,TupleElement26,TupleElement27,TupleElement28,TupleElement29,TupleElement30,TupleElement31,TupleElement32,TupleElement33,TupleElement34,TupleElement35,TupleElement36,TupleElement37,TupleElement38,TupleElement39,TupleElement40,TupleElement41,TupleElement42,TupleElement43,TupleElement44,TupleElement45,TupleElement46,TupleElement47,TupleElement48,TupleElement49,TupleElement50,TupleElement51) as frame_support::traits::hooks::OnFinalize<BlockNumber>>::on_finalize::habc7a9ee01c0a93b
           4: 0x3b7d60 - battery_station_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::finalize_block::h095968036104c663
           5: 0x4bccca - battery_station_runtime.wasm!BlockBuilder_finalize_block
    1: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
       WASM backtrace:
       error while executing at wasm backtrace:
           0: 0x6502d4 - battery_station_runtime.wasm!rust_begin_unwind
           1: 0x5e6eb5 - battery_station_runtime.wasm!core::panicking::panic_fmt::he905bcb57f481db7
           2: 0x5e6aa5 - battery_station_runtime.wasm!core::option::expect_failed::hec30617e7e3a43fd
           3: 0x2d4cf7 - battery_station_runtime.wasm!<(TupleElement0,TupleElement1,TupleElement2,TupleElement3,TupleElement4,TupleElement5,TupleElement6,TupleElement7,TupleElement8,TupleElement9,TupleElement10,TupleElement11,TupleElement12,TupleElement13,TupleElement14,TupleElement15,TupleElement16,TupleElement17,TupleElement18,TupleElement19,TupleElement20,TupleElement21,TupleElement22,TupleElement23,TupleElement24,TupleElement25,TupleElement26,TupleElement27,TupleElement28,TupleElement29,TupleElement30,TupleElement31,TupleElement32,TupleElement33,TupleElement34,TupleElement35,TupleElement36,TupleElement37,TupleElement38,TupleElement39,TupleElement40,TupleElement41,TupleElement42,TupleElement43,TupleElement44,TupleElement45,TupleElement46,TupleElement47,TupleElement48,TupleElement49,TupleElement50,TupleElement51) as frame_support::traits::hooks::OnFinalize<BlockNumber>>::on_finalize::habc7a9ee01c0a93b
           4: 0x3b7d60 - battery_station_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::finalize_block::h095968036104c663
           5: 0x4bccca - battery_station_runtime.wasm!BlockBuilder_finalize_block

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::new
   1: <cumulus_client_consensus_proposer::Proposer<B,T> as cumulus_client_consensus_proposer::ProposerInterface<B>>::propose::{{closure}}::{{closure}}
   2: <cumulus_client_consensus_proposer::Proposer<B,T> as cumulus_client_consensus_proposer::ProposerInterface<B>>::propose::{{closure}}
   3: nimbus_consensus::collators::collate::{{closure}}
   4: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::future::future::Future>::poll
   5: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
   6: <sc_service::task_manager::prometheus_future::PrometheusFuture<T> as core::future::future::Future>::poll
   7: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll
   8: <tracing_futures::Instrumented<T> as core::future::future::Future>::poll
   9: tokio::runtime::task::core::Core<T,S>::poll
  10: tokio::runtime::task::harness::Harness<T,S>::poll
  11: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
  12: tokio::runtime::scheduler::multi_thread::worker::Context::run
  13: tokio::runtime::context::scoped::Scoped<T>::set
  14: tokio::runtime::context::runtime::enter_runtime
  15: tokio::runtime::scheduler::multi_thread::worker::run
  16: tokio::runtime::task::core::Core<T,S>::poll
  17: tokio::runtime::task::harness::Harness<T,S>::poll
  18: tokio::runtime::blocking::pool::Inner::run
  19: std::sys::backtrace::__rust_begin_short_backtrace
  20: core::ops::function::FnOnce::call_once{{vtable.shim}}
  21: std::sys::pal::unix::thread::Thread::new::thread_start
  22: start_thread
             at ./nptl/pthread_create.c:442:8
  23: __GI___clone3
             at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81:0 }

This happens here. It looks bad, but it happens, because asynchronous backing is disabled. We used ExpectParentIncluded here from here to allow us to gracefully migrate to asynchronous backing in the next runtime upgrade.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

[mergify]

This pull request is now in conflicts. Could you fix it @Chralt98? 🙏

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chralt98-update-dependencies-stable2407@8c67ad2). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                            Coverage Diff                             @@
##             chralt98-update-dependencies-stable2407    #1434   +/-   ##
==========================================================================
  Coverage                                           ?   93.38%           
==========================================================================
  Files                                              ?      181           
  Lines                                              ?    34625           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?    32334           
  Misses                                             ?     2291           
  Partials                                           ?        0           

Flag	Coverage Δ
tests	93.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.