Skip to content

Update dependencies to polkadot-stable2409#1421

Merged
Chralt98 merged 4 commits intochralt98-update-dependencies-stable2407from
chralt98-update-dependencies-stable2407-part-1
Jun 5, 2025
Merged

Update dependencies to polkadot-stable2409#1421
Chralt98 merged 4 commits intochralt98-update-dependencies-stable2407from
chralt98-update-dependencies-stable2407-part-1

Conversation

@Chralt98
Copy link
Copy Markdown
Member

@Chralt98 Chralt98 commented Apr 14, 2025

What does it do?

Updates all dependencies from 1.1.0 to stable2409. It removes try-runtime-cli since this is its own separate tool now. It removes pallet-contracts from the runtime. It updates the Cargo.lock for the newest crate dependencies.

What important points should reviewers know?

The moonbeam fork won't fully compile using cargo build, because there are missing changes in the paritytech polkadot-sdk that exist in the fork of the polkadot-sdk from moonbeam. However, the compilation of the moonbeam repository isn't necessary as long as all dependencies zeitgeist requires from the moonbeam repository compile successfully, which is the case for parachain-staking and moonbeam-vrf.

After cargo update some crates had to be adjusted individually by cargo update -p <crate_name> --precise <version> to get the node and runtime to compile. A trick is here to peek at the dependencies from moonbeam or polkadot-sdk to know which versions to upgrade or downgrade to. Some crates needed to be downgraded, while others needed an upgrade.

  • Always adjust all dependencies to use the same Substrate dependencies to avoid duplicate dependencies and resulting compilation errors
  • For other dependencies, ensure that as many crates as possible use the same version to avoid downloading and compiling multiple version of the same crate
  • Figure out if existing patches are still needed and if not, remove them

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Apr 14, 2025
@Chralt98 Chralt98 self-assigned this Apr 14, 2025
@Chralt98 Chralt98 changed the title Update dependencies to stable2409 Update dependencies to polkadot-stable2409 Apr 14, 2025
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:in-progress The pull requests is currently being worked on labels Jun 5, 2025
@Chralt98 Chralt98 merged commit 5dd64ee into chralt98-update-dependencies-stable2407 Jun 5, 2025
1 of 10 checks passed
@Chralt98 Chralt98 deleted the chralt98-update-dependencies-stable2407-part-1 branch June 5, 2025 08:45
Chralt98 added a commit that referenced this pull request Jul 4, 2025
* Update dependencies to polkadot-stable2409 (#1421)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust compiler version, cargo fmt (#1422)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* correct weights for common runtime

* Update zeitgeist pallets for new polkadot version (#1423)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version (#1424)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* Update xcm integration tests for new polkadot version (#1427)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* Update client for new polkadot version (#1428)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* activate async backing in parachain client

* Update benchmark code for new polkadot version (#1429)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* add genesis builder for benchmarks to runtime

* remove cumulus primitives storage weight reclaim

* remove additional new_full_parts from storage weight reclaim

* update code for benchmark script

* correct host functions

* downgrade rustc version, use frame-omni-bencher, use wasm executor

* update github workflows for benchmarking

* fix treasury dependency for benchmarks

* update pallet timestamp configuration

* add weights

* add storage weight reclaim

* activate async backing in parachain client

* update weights

* update weights

* Fix clippy issues (#1431)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* add genesis builder for benchmarks to runtime

* remove cumulus primitives storage weight reclaim

* remove additional new_full_parts from storage weight reclaim

* update code for benchmark script

* correct host functions

* downgrade rustc version, use frame-omni-bencher, use wasm executor

* update github workflows for benchmarking

* fix treasury dependency for benchmarks

* update pallet timestamp configuration

* add weights

* fix clippy

* fmt

* use DispatchResultWithPostInfo from dispatch

* fix message queue

* fmt

* update rust toolchain

* use specific version for grcov

* add runtime-benchmarks feature for orml asset registry

* use noop message processor for parachain benchmarks

* use default benchmark helper for pm mock

* fix benchmark helper not found error

* add storage weight reclaim

* add std to cumulus primitives storage weight reclaim

* activate async backing in parachain client

* update copyrights

* Add necessary storage migrations (#1432)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* add genesis builder for benchmarks to runtime

* remove cumulus primitives storage weight reclaim

* remove additional new_full_parts from storage weight reclaim

* update code for benchmark script

* correct host functions

* downgrade rustc version, use frame-omni-bencher, use wasm executor

* update github workflows for benchmarking

* fix treasury dependency for benchmarks

* update pallet timestamp configuration

* add weights

* fix clippy

* fmt

* use DispatchResultWithPostInfo from dispatch

* fix message queue

* fmt

* update rust toolchain

* use specific version for grcov

* add runtime-benchmarks feature for orml asset registry

* use noop message processor for parachain benchmarks

* use default benchmark helper for pm mock

* fix benchmark helper not found error

* add storage weight reclaim

* add std to cumulus primitives storage weight reclaim

* add necessary polkadot sdk migrations

* add necessary migrations

* add pallet parachain staking migrations

* add custom migrate_old_collator_snapshot weight

* update Makefile

* remove MultiplyRoundLenBy2 migration in favor of MigrateRoundWithFirstSlot

* activate async backing in parachain client

* use monotonically increase for async backing

* update parachain staking dependency

* fmt

* update copyrights

* Remove async backing (#1434)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* add genesis builder for benchmarks to runtime

* remove cumulus primitives storage weight reclaim

* remove additional new_full_parts from storage weight reclaim

* update code for benchmark script

* correct host functions

* downgrade rustc version, use frame-omni-bencher, use wasm executor

* update github workflows for benchmarking

* fix treasury dependency for benchmarks

* update pallet timestamp configuration

* add weights

* fix clippy

* fmt

* use DispatchResultWithPostInfo from dispatch

* fix message queue

* fmt

* update rust toolchain

* use specific version for grcov

* add runtime-benchmarks feature for orml asset registry

* use noop message processor for parachain benchmarks

* use default benchmark helper for pm mock

* fix benchmark helper not found error

* add storage weight reclaim

* add std to cumulus primitives storage weight reclaim

* add necessary polkadot sdk migrations

* add necessary migrations

* add pallet parachain staking migrations

* add custom migrate_old_collator_snapshot weight

* update Makefile

* remove MultiplyRoundLenBy2 migration in favor of MigrateRoundWithFirstSlot

* activate async backing in parachain client

* use monotonically increase for async backing

* remove async backing

* update parachain staking dependency

* fmt

* updated copyrights

* Update chopsticks zombienet integration tests (#1436)

* Update dependencies to stable2409, remove try-runtime-cli, pallet-contracts, update Cargo.lock

* update rust toolchain version, fix compiler warnings

* update rust toolchain

* update some non-substrate dependencies

* Fixes for new rust version, cargo fmt

* correct weight files

* update zeitgeist pallets for new polkadot version

* correct weights for common runtime

* Update runtime according to new polkadot version

* adapt runtime to newest dependency versions

* update runtime

* update runtime

* update runtime

* update runtime

* adapt runtime

* update runtime

* use latest Location for pallet asset tx payment

* fix irrefutable if let pattern

* add benchmarks

* update maximum block weight and block time

* use metadata hash feature, add pov storage reclaim extension

* update zeitgeist runtime

* fix runtime error

* correct code for feature test

* adjust xcm integration tests

* update consensus hook to satisfy xcm integration tests

* add issue for xcm integration tests for consensus hook

* update xcm zeitgeist it tests using polkadot emulated chain

* cargo fmt

* update service from client

* update service parachain

* update client

* update client

* fix parachain node

* update client code

* fix client compilation for all features

* cargo fmt

* add genesis builder for benchmarks to runtime

* remove cumulus primitives storage weight reclaim

* remove additional new_full_parts from storage weight reclaim

* update code for benchmark script

* correct host functions

* downgrade rustc version, use frame-omni-bencher, use wasm executor

* update github workflows for benchmarking

* fix treasury dependency for benchmarks

* update pallet timestamp configuration

* add weights

* fix clippy

* fmt

* use DispatchResultWithPostInfo from dispatch

* fix message queue

* fmt

* update rust toolchain

* use specific version for grcov

* add runtime-benchmarks feature for orml asset registry

* use noop message processor for parachain benchmarks

* use default benchmark helper for pm mock

* fix benchmark helper not found error

* add storage weight reclaim

* add std to cumulus primitives storage weight reclaim

* add necessary polkadot sdk migrations

* add necessary migrations

* add pallet parachain staking migrations

* add custom migrate_old_collator_snapshot weight

* update Makefile

* remove MultiplyRoundLenBy2 migration in favor of MigrateRoundWithFirstSlot

* activate async backing in parachain client

* use monotonically increase for async backing

* remove async backing

* update parachain staking dependency

* fmt

* update zombienet configuration

* update integration tests

* update zombienet configs

* Remove storage weight reclaim (#1437)

remove storage weight reclaim

* fmt

* remove storage weight reclaim

* use older version for frame-omni-bencher

* downgrade destination xcm version for integration test

* apply fixes

* fmt

* add coderabbit pull request reviews badge to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:accepted This pull request is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant