markdown_preview: Improve the link decoration logic #39905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Simek
changed the title
danilo-leal
added a commit
that referenced
this pull request
Oct 14, 2025
# Why Follow up to: * #39905 # How Apply accented color to links in message content inside Blame tooltip, to match appearance in Markdown Preview panel. Release Notes: - Improved appearance of links in message content inside Blame tooltip. # Preview ### Before <img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 37" src="https://github.com/user-attachments/assets/33ab4fb5-7910-4d28-9152-c692d6ddeaa6" /> ### After <img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 10" src="https://github.com/user-attachments/assets/38082c5c-50d6-4fb3-90ca-410accff9aad" /> --------- Co-authored-by: Danilo Leal <[email protected]>
danilo-leal
approved these changes
Oct 17, 2025
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
…s#40124) # Why Follow up to: * zed-industries#39905 # How Apply accented color to links in message content inside Blame tooltip, to match appearance in Markdown Preview panel. Release Notes: - Improved appearance of links in message content inside Blame tooltip. # Preview ### Before <img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 37" src="https://github.com/user-attachments/assets/33ab4fb5-7910-4d28-9152-c692d6ddeaa6" /> ### After <img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 10" src="https://github.com/user-attachments/assets/38082c5c-50d6-4fb3-90ca-410accff9aad" /> --------- Co-authored-by: Danilo Leal <[email protected]>
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
…9905) Closes zed-industries#39838 Refs: * zed-industries#39149 (comment) # How After digging a bit more to find out why raw links are not colored in Markdown renderer I have found a simpler approach to applying color decoration, which also fixed the lack of colors on raw links mentioned in issue and comment above. Release Notes: - Improved decoration logic for links in Markdown # Preview <img width="1712" height="820" alt="Screenshot 2025-10-09 at 23 39 09" src="https://github.com/user-attachments/assets/3864cb6c-3fc6-4110-8067-6158cd4b58f5" />
|
Thank you @Simek! |
|
Not sure what's up, but I'm still missing the styling on my end on the latest nightly. I can do into it more later on: 
|
|
Oops! Sorry, I looked at the timestamp of the PR, and not when it was merged. All looks great on my end with a fresh compile! My apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39838
Refs:
How
After digging a bit more to find out why raw links are not colored in Markdown renderer I have found a simpler approach to applying color decoration, which also fixed the lack of colors on raw links mentioned in issue and comment above.
Release Notes:
Preview