markdown_preview: Stylize links using accented text color #39149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
danilo-leal
reviewed
Sep 29, 2025
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
This is looking great, good catch! Added one comment there before we move on.
Simek
commented
Sep 29, 2025
danilo-leal
approved these changes
Oct 2, 2025
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looking great, thanks for picking this up!
Collaborator
|
Hey @Simek, nice work on this! Should we also stylize raw, non-embedded links too? 
|
Contributor
Author
|
Hey @JosephTLyons, thanks! And yeah, I agree that would be nice to have unified appearance for all possible links within Markdown, had to miss this case, can look at this tomorrow and work on the follow-up PR if you want. 🙂 |
Collaborator
|
I'm not sure what that mind end up entailing, if itll be straight forward or not, but if you're up for it, that would be rad. Of course, no pressure. Really appreciate the help improving markdown preview. The last 2-3 releases added a lot of good fixes. |
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Oct 11, 2025
…ries#39149) # How Emphasize links in Markdown Preview text using accented text color. > [!note] > I have chosen the accent color for links since it was looking fine with all bundled by default themes, but I'm happy to alter the color to use different theme value, if you have better candidates. Release Notes: - Stylize links using accented text color in Markdown Preview # Preview ### Before <img width="1606" height="1066" alt="Screenshot 2025-09-29 at 22 19 38" src="https://github.com/user-attachments/assets/59b6ee72-4523-42fb-a468-9c694d30b5df" /> ### After <img width="1652" height="1066" alt="Screenshot 2025-09-29 at 22 18 20" src="https://github.com/user-attachments/assets/e00e3742-6435-4c1d-aaaa-e6332719db17" /> <img width="1652" height="1066" alt="Screenshot 2025-09-29 at 22 18 47" src="https://github.com/user-attachments/assets/a1b76f4a-c4d2-4ca8-ae3c-fc4dc5d55e01" /> **Release notes** <img width="2090" height="582" alt="Screenshot 2025-09-29 at 22 36 33" src="https://github.com/user-attachments/assets/81d6df12-83bd-4794-b71e-5a1fd40f0140" /> <img width="2090" height="582" alt="Screenshot 2025-09-29 at 22 40 41" src="https://github.com/user-attachments/assets/aa820767-b82b-42a5-aa5b-b0d3d22ac5e3" />
danilo-leal
pushed a commit
that referenced
this pull request
Oct 17, 2025
Closes #39838 Refs: * #39149 (comment) # How After digging a bit more to find out why raw links are not colored in Markdown renderer I have found a simpler approach to applying color decoration, which also fixed the lack of colors on raw links mentioned in issue and comment above. Release Notes: - Improved decoration logic for links in Markdown # Preview <img width="1712" height="820" alt="Screenshot 2025-10-09 at 23 39 09" src="https://github.com/user-attachments/assets/3864cb6c-3fc6-4110-8067-6158cd4b58f5" />
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
…9905) Closes zed-industries#39838 Refs: * zed-industries#39149 (comment) # How After digging a bit more to find out why raw links are not colored in Markdown renderer I have found a simpler approach to applying color decoration, which also fixed the lack of colors on raw links mentioned in issue and comment above. Release Notes: - Improved decoration logic for links in Markdown # Preview <img width="1712" height="820" alt="Screenshot 2025-10-09 at 23 39 09" src="https://github.com/user-attachments/assets/3864cb6c-3fc6-4110-8067-6158cd4b58f5" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How
Emphasize links in Markdown Preview text using accented text color.
Note
I have chosen the accent color for links since it was looking fine with all bundled by default themes, but I'm happy to alter the color to use different theme value, if you have better candidates.
Release Notes:
Preview
Before
After
Release notes