Skip to content

fixed favicon method inconsistency with document and usages #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jxlwqq merged 3 commits into from
Mar 11, 2022
Merged

fixed favicon method inconsistency with document and usages #5436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ba4d6e
fixed favicon method consistency with document and usages
ZsgsDesign Oct 11, 2021
1b9974f
Merge branch 'z-song:master' into master
ZsgsDesign Mar 11, 2022
dd77dd8
add phpdoc Renderable param hint to Box widget
ZsgsDesign Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ public function title()
*
* @return string|void
*/
public function favicon($favicon = null)
public static function favicon($favicon = null)
{
if (is_null($favicon)) {
return static::$favicon;
Expand Down
4 changes: 2 additions & 2 deletions src/Widgets/Box.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __construct($title = '', $content = '', $footer = '')
/**
* Set box content.
*
* @param string $content
* @param string|Renderable $content
*
* @return $this
*/
Expand All @@ -80,7 +80,7 @@ public function content($content)
/**
* Set box footer.
*
* @param string $footer
* @param string|Renderable $footer
*
* @return $this
*/
Expand Down