fixed favicon method inconsistency with document and usages

[ZsgsDesign]

In documents and views, favicon() was used like:

Admin::favicon('favicon.png');

@if(!is_null($favicon = Admin::favicon()))
    <link rel="shortcut icon" href="{{$favicon}}">
@endif

However, in Encore\Admin\Admin, it is inconsistently designated as public function rather than public static function. It doesn't affect actual usage right now but it is an inconsistency that should be fixed.

    /**
     * @param null|string $favicon
     *
     * @return string|void
     */
    public function favicon($favicon = null)
    {
        if (is_null($favicon)) {
            return static::$favicon;
        }

        static::$favicon = $favicon;
    }

[jxlwqq]

Facades provide a "static" interface to classes that are available in the application's service container.

https://laravel.com/docs/8.x/facades

[ZsgsDesign]

@jxlwqq Still, when making declarations of methods, static methods should be consistent with usages, it is not a bug but about coding consistency. As stated earlier, it doesn't affect actual usage. But I still believe we should change that, as other static methods all declared with proper static.

[ZsgsDesign]

Also, could you check another PR I opened earlier this morning at laravel-admin-extensions/scheduling#20？

[jxlwqq]

use Encore\Admin\Facades\Admin;
Admin::favicon();

[ZsgsDesign]

@jxlwqq As stated earlier, it doesn't affect actual usage. You can even call Encore\Admin\Admin::favicon() and it would be fine. It is just about code consistency, that other parts of Encore\Admin\Admin methods like js or style all uses static, and Laravel codes either. You can see Arr and Str all uses static declarations:

    /**
     * Cross join the given arrays, returning all possible permutations.
     *
     * @param  iterable  ...$arrays
     * @return array
     */
    public static function crossJoin(...$arrays)
    {
        $results = [[]];

        foreach ($arrays as $index => $array) {
            $append = [];

            foreach ($results as $product) {
                foreach ($array as $item) {
                    $product[$index] = $item;

                    $append[] = $product;
                }
            }

            $results = $append;
        }

        return $results;
    }

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jxlwqq]

thanks