Skip to content

fix: support file URIs for middleware #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoqunjiang merged 1 commit into from
Jul 28, 2025
+2 −1
Merged

fix: support file URIs for middleware #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/launch-editor-middleware/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ module.exports = (specifiedEditor, srcRoot, onErrorCallback) => {
res.statusCode = 500
res.end(`launch-editor-middleware: required query param "file" is missing.`)
} else {
launch(path.resolve(srcRoot, file), specifiedEditor, onErrorCallback)
const resolved = file.startsWith('file://') ? file : path.resolve(srcRoot, file)
Copy link
Contributor

@dominikg dominikg Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be

const resolved = file.startsWith('file://') ? file : `file://${path.resolve(srcRoot, file)}`

(potentially needs special handling for drive letter on windows too)

Copy link
Contributor Author

@sapphi-red sapphi-red Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

launch-editor supports normal paths, so it should be fine.

launch-editor/packages/launch-editor/index.js

Line 70 in 373558c

const parsed = parseFile(file)

launch-editor/packages/launch-editor/index.js

Lines 52 to 54 in 373558c

if (file.startsWith('file://')) {
file = require('url').fileURLToPath(file)
}

launch(resolved, specifiedEditor, onErrorCallback)
res.end()
}
}
Expand Down