fix: support file URIs for middleware#95
Merged
haoqunjiang merged 1 commit intoyyx990803:masterfrom Jul 28, 2025
Merged
Conversation
patak-cat
approved these changes
May 14, 2025
haoqunjiang
approved these changes
Jul 28, 2025
dominikg
reviewed
Aug 7, 2025
| res.end(`launch-editor-middleware: required query param "file" is missing.`) | ||
| } else { | ||
| launch(path.resolve(srcRoot, file), specifiedEditor, onErrorCallback) | ||
| const resolved = file.startsWith('file://') ? file : path.resolve(srcRoot, file) |
Contributor
There was a problem hiding this comment.
shouldn't it be
const resolved = file.startsWith('file://') ? file : `file://${path.resolve(srcRoot, file)}`(potentially needs special handling for drive letter on windows too)
Contributor
Author
There was a problem hiding this comment.
launch-editor supports normal paths, so it should be fine.
launch-editor/packages/launch-editor/index.js
Lines 52 to 54 in 373558c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the file query was passed to
path.resolve(srcRoot, file), file urls did not work when usinglaunch-editor-middleware. This PR fixes that.refs #53 #91