sudo commands in shell mode

[lazysegtree]

Running sudo in shell mode causes terminal to hang, and password prompt appear at left bottom corner. Also it times out after 5 seconds, focussing spf again.

Mentioned by users here - #1196 (comment)

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Similar Issues

Possible Duplicates

• UI freeze when executing TUI apps in Shell Mode #1149

Related Issues

• Getting "Terminal size too small" error when trying to open spf from /tmp directory #585
• Superfile sends a messy output to terminal after exiting #720
• Sudo privileges #864
• Confusing interface display - For windows and Arch linux users. #544

👤 Suggested Assignees

• yedhink
• lazysegtree
• AyalMoran
• rami-shalhoub
• andrew2558

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[xelavopelk]

@lazysegtree
Now, the output cannot be generated after all the execution. After the "[sudo] password for" prompt, please enter the password. Where we need write pass?

1. on promt ":"
2. on the output field between output strings
   Here i pass password automatically after read "[sudo] password for klea: "

Could you please advise me on the best way to make a callback to a modal window in the bubbletea framework?

[lazysegtree]

@xelavopelk shell mode should not be used for any interactive input. This is not intended to replicate the shell. sudo command should fail by default if spf wasn't ran as root

[xelavopelk]

@xelavopelk shell mode should not be used for any interactive input. This is not intended to replicate the shell. sudo command should fail by default if spf wasn't ran as root

I suggest running the command in the pty to detect the the prompt to interactive mode.

[lazysegtree]

The philosophy of linux is do one that and do it right. We don't intend to make spf shell mode as full fledged shell.

Handling interactive sudo is just one of thousand other things that are needed to be done if we keep on leaning towards making it more close to real shell.

[xelavopelk]

The philosophy of linux is do one that and do it right. We don't intend to make spf shell mode as full fledged shell.

Handling interactive sudo is just one of thousand other things that are needed to be done if we keep on leaning towards making it more close to real shell.

i don't intend make new shell. i suggest the way to detect interactive mode and then return error when sudo wants password.

[lazysegtree]

It is better to disable the interactive mode altogether instead of having to detect it.

The problem with sudo is that it will bypass stdin and stdout that are controlled by exec.Command and directly read/write to terminal device tty. I don't know the exact mechanism, though.

tty is not controlled by bubbletea, so the layout breaks.

What we want is that the process executed by our shell should not be reading from tty or writing to tty.

Although we should still have access to their stdout.

Something libraries like https://github.com/creack/pty or https://pkg.go.dev/golang.org/x/term can be useful. Or manually setting SysProcAttr of the command could help in this case. Although I would very much prefer using a standard library.

[lazysegtree]

@xelavopelk Also check out how yazi handles it. It allows interactive commands, but runs them in a separate terminal. Thats also a good way to handle it. But I think we would also like to have access to command's stdout.