Skip to content

fix(fslib): handle float timestamps in convertToBigIntStats #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 6 commits into from
Nov 26, 2025
+63 −11
Merged

fix(fslib): handle float timestamps in convertToBigIntStats #6988

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04ea344
fix(fslib): handle float timestamps in convertToBigIntStats
nelsondude Nov 24, 2025
cf7fc6a
chore: add version bump for @yarnpkg/fslib
nelsondude Nov 24, 2025
c92bf93
chore: update version decisions for dependent packages
nelsondude Nov 24, 2025
c4cbae1
fix: preserve fractional millisecond precision in nanosecond conversion
nelsondude Nov 24, 2025
6c649bc
Adds test
arcanis Nov 26, 2025
7ddbbb6
Adds test
arcanis Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .yarn/versions/78344001.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
releases:
"@yarnpkg/fslib": patch
2 changes: 1 addition & 1 deletion packages/yarnpkg-fslib/sources/statUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export function convertToBigIntStats(stats: Stats): BigIntStats {
const element = stats[key as keyof typeof stats];
if (typeof element === `number`) {
// @ts-expect-error Typescript isn't able to tell this is valid
bigintStats[key as keyof typeof bigintStats] = BigInt(element);
bigintStats[key as keyof typeof bigintStats] = BigInt(Math.floor(element));
} else if (nodeUtils.types.isDate(element)) {
// @ts-expect-error Typescript isn't able to tell this is valid
bigintStats[key as keyof typeof bigintStats] = new Date(element);
Expand Down
Loading